From: Ingo Molnar <mingo@elte.hu>
To: Yu Zhao <yu.zhao@intel.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"jbarnes@virtuousgeek.org" <jbarnes@virtuousgeek.org>,
"randy.dunlap@oracle.com" <randy.dunlap@oracle.com>,
"grundler@parisc-linux.org" <grundler@parisc-linux.org>,
"achiang@hp.com" <achiang@hp.com>,
"matthew@wil.cx" <matthew@wil.cx>,
"rdreier@cisco.com" <rdreier@cisco.com>,
"greg@kroah.com" <greg@kroah.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH 8/15 v5] PCI: add boot options to reassign resources
Date: Wed, 22 Oct 2008 09:19:09 +0200 [thread overview]
Message-ID: <20081022071909.GB27637@elte.hu> (raw)
In-Reply-To: <20081021114959.GI3185@yzhao12-linux.sh.intel.com>
* Yu Zhao <yu.zhao@intel.com> wrote:
> +static char *pci_assign_pio;
> +static char *pci_assign_mmio;
> +
> +static int pcibios_bus_resource_needs_fixup(struct pci_bus *bus)
> +{
> + int i;
> + int type = 0;
> + int domain, busnr;
> +
> + if (!bus->self)
> + return 0;
> +
> + for (i = 0; i < 2; i++) {
> + char *str = i ? pci_assign_pio : pci_assign_mmio;
> + while (str && *str) {
please put a newline after local variable defitions.
> + for (i = 0; i < PCI_BUS_NUM_RESOURCES; i++) {
> + struct resource *res = bus->resource[i];
> + if (!res)
ditto.
nice debug feature!
Ingo
next prev parent reply other threads:[~2008-10-22 7:19 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 11:40 [PATCH 0/15 v5] PCI: Linux kernel SR-IOV support Yu Zhao
2008-10-21 11:44 ` [PATCH 1/15 v5] PCI: remove unnecessary arg of pci_update_resource() Yu Zhao
2008-10-21 11:44 ` Yu Zhao
2008-10-21 11:44 ` [PATCH 2/15 v5] PCI: define PCI resource names in an 'enum' Yu Zhao
2008-10-21 11:44 ` Yu Zhao
2008-10-21 11:45 ` [PATCH 3/15 v5] PCI: export __pci_read_base Yu Zhao
2008-10-21 11:45 ` Yu Zhao
2008-10-21 11:47 ` [PATCH 4/15 v5] PCI: make pci_alloc_child_bus() be able to handle NULL bridge Yu Zhao
2008-10-21 11:47 ` Yu Zhao
2008-10-21 11:48 ` [PATCH 5/15 v5] PCI: add a wrapper for resource_alignment() Yu Zhao
2008-10-21 11:48 ` Yu Zhao
2008-10-21 11:48 ` [PATCH 6/15 v5] PCI: add a new function to map BAR offset Yu Zhao
2008-10-21 11:48 ` Yu Zhao
2008-10-21 11:48 ` [PATCH 7/15 v5] PCI: cleanup pcibios_allocate_resources() Yu Zhao
2008-10-21 11:48 ` Yu Zhao
2008-10-21 11:49 ` [PATCH 8/15 v5] PCI: add boot options to reassign resources Yu Zhao
2008-10-21 11:49 ` Yu Zhao
2008-10-22 7:19 ` Ingo Molnar
2008-10-22 7:19 ` Ingo Molnar [this message]
2008-10-21 11:50 ` [PATCH 9/15 v5] PCI: add boot option to align MMIO resource Yu Zhao
2008-10-21 11:50 ` Yu Zhao
2008-10-21 11:51 ` [PATCH 10/15 v5] PCI: cleanup pci_bus_add_devices() Yu Zhao
2008-10-21 11:51 ` Yu Zhao
2008-10-21 11:52 ` [PATCH 11/15 v5] PCI: split a new function from pci_bus_add_devices() Yu Zhao
2008-10-21 11:52 ` Yu Zhao
2008-10-21 11:53 ` [PATCH 12/15 v5] PCI: support the SR-IOV capability Yu Zhao
2008-10-21 11:53 ` Yu Zhao
2008-10-21 16:50 ` Greg KH
2008-10-22 3:05 ` Zhao, Yu
2008-10-22 3:05 ` Zhao, Yu
2008-10-21 16:50 ` Greg KH
2008-10-21 11:53 ` [PATCH 13/15 v5] PCI: reserve bus range for the SR-IOV device Yu Zhao
2008-10-21 11:53 ` Yu Zhao
2008-10-21 11:54 ` [PATCH 14/15 v5] PCI: document the SR-IOV Yu Zhao
2008-10-21 11:54 ` Yu Zhao
2008-10-21 11:54 ` [PATCH 15/15 v5] PCI: document the new PCI boot parameters Yu Zhao
2008-10-21 11:54 ` Yu Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081022071909.GB27637@elte.hu \
--to=mingo@elte.hu \
--cc=achiang@hp.com \
--cc=greg@kroah.com \
--cc=grundler@parisc-linux.org \
--cc=jbarnes@virtuousgeek.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=randy.dunlap@oracle.com \
--cc=rdreier@cisco.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=yinghai@kernel.org \
--cc=yu.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.