From: Dave Chinner <david@fromorbit.com>
To: Alexander Beregalov <a.beregalov@gmail.com>
Cc: lachlan@sgi.com, Christoph Hellwig <hch@infradead.org>,
Arjan van de Ven <arjan@infradead.org>,
xfs@oss.sgi.com, linux-next@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: BUG: sleeping function called from invalid context at kernel/rwsem.c:131 XFS? (was: Re: linux-next: Tree for October 17)
Date: Wed, 22 Oct 2008 19:28:29 +1100 [thread overview]
Message-ID: <20081022082828.GN18495@disturbed> (raw)
In-Reply-To: <a4423d670810220121k27ab3d1dp1921ea282786eebc@mail.gmail.com>
On Wed, Oct 22, 2008 at 12:21:23PM +0400, Alexander Beregalov wrote:
> > Ah, OK, I see the problem, though I don't understand why I'm not
> > seeing the might_sleep() triggering all the time given that I always
> > build with:
> >
> > $ grep SLEEP .config
> > CONFIG_DEBUG_SPINLOCK_SLEEP=y
> >
> > Basically the above commit moved xfs_ilock() inside
> > radix_tree_preload()/radix_tree_preload_end(), which means we are
> > taking a rwsem() while we have an elevated preempt count. I'll
> > get a patch out to fix it.
> Could it cause the I/O dead lock or should I continue trying to reproduce it?
The deadlock wouldn't be produced by the same thing that
produced the sleeping-in-atomic warning. The missed unlock that
I also fixed in the patch I just sent could possibly have caused
that, but I'm just speculating on that...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-10-22 8:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 12:43 BUG: sleeping function called from invalid context at kernel/rwsem.c:131 XFS? (was: Re: linux-next: Tree for October 17) Alexander Beregalov
2008-10-17 16:41 ` Christoph Hellwig
2008-10-17 16:54 ` Alexander Beregalov
2008-10-17 16:57 ` Christoph Hellwig
2008-10-17 17:13 ` Alexander Beregalov
2008-10-17 20:37 ` Christoph Hellwig
2008-10-17 20:55 ` Arjan van de Ven
2008-10-17 20:55 ` Arjan van de Ven
2008-10-17 20:55 ` Arjan van de Ven
2008-10-20 14:58 ` Alexander Beregalov
2008-10-20 16:33 ` Christoph Hellwig
2008-10-20 17:13 ` Alexander Beregalov
2008-10-20 22:35 ` Dave Chinner
2008-10-21 11:42 ` Alexander Beregalov
2008-10-21 11:42 ` Alexander Beregalov
2008-10-22 7:58 ` Dave Chinner
2008-10-22 8:21 ` Alexander Beregalov
2008-10-22 8:21 ` Alexander Beregalov
2008-10-22 8:28 ` Dave Chinner [this message]
2008-10-22 8:25 ` Dave Chinner
2008-10-22 8:25 ` Dave Chinner
2008-10-22 9:12 ` Alexander Beregalov
2008-10-22 9:12 ` Alexander Beregalov
2008-10-22 10:13 ` Christoph Hellwig
2008-10-22 10:13 ` Christoph Hellwig
2008-10-22 21:10 ` Dave Chinner
2008-10-22 15:06 ` BUG: sleeping function called from invalid context at kernel/rwsem.c:131 XFS? Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081022082828.GN18495@disturbed \
--to=david@fromorbit.com \
--cc=a.beregalov@gmail.com \
--cc=arjan@infradead.org \
--cc=hch@infradead.org \
--cc=lachlan@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.