Re: [patch 1/7] mm: write_cache_pages writepage error fix

[Andrew Morton <akpm@linux-foundation.org>]

On Wed, 22 Oct 2008 11:36:32 +0200 Nick Piggin <npiggin@suse.de> wrote:

> > >  				wbc->encountered_congestion = 1;
> > > 
> > > -- 
> > 
> > I don't think I like the implementation much.
> > 
> > In all cases in that function where we set done=1, we want to bale out
> > right now at this page, rather than processing the remaining pages in
> > the pagevec.
> > 
> > So it would be better to implement a bit of code which releases the
> > pagevec pages and then breaks out of the loop.  Then this bug
> > automatically gets fixed.
> 
> I had almost exactly that at some point, then I rethought it because it
> was a bigger behaviour change than the bugfix-only.
> 
> I thought the !done thing must be just for batching and to process the
> pages already looked up in the pagevec.
> 
> I'll need to backport at least some of these to stable -- any chance of
> making the change you suggest toward the end of the patchset?

That works.

> Let me
> know if you want a patch or will do one yourself.

I couldn't hope to match your level of testing ;)