From: Matthew Wilcox <matthew@wil.cx>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH 2/2] ia64: implement interrupt-enabling rwlocks
Date: Wed, 22 Oct 2008 11:30:05 +0000 [thread overview]
Message-ID: <20081022113005.GC26094@parisc-linux.org> (raw)
In-Reply-To: <1224664534.4430.42.camel@elijah.suse.cz>
On Wed, Oct 22, 2008 at 10:35:34AM +0200, Petr Tesarik wrote:
> +#define __raw_read_lock_flags(rw, flags) \
I appreciate that ia64 is full of overlength lines, but could you not
add more of them? There's no reason not to delete one of the tabs on
these lines.
> +} while(0)
checkpatch.pl says you need a space between 'while' and '(0)'.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
prev parent reply other threads:[~2008-10-22 11:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 8:35 [PATCH 2/2] ia64: implement interrupt-enabling rwlocks Petr Tesarik
2008-10-22 11:30 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081022113005.GC26094@parisc-linux.org \
--to=matthew@wil.cx \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.