From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wireless: fix regdom passing semantics
Date: Wed, 22 Oct 2008 04:37:51 -0700 [thread overview]
Message-ID: <20081022113751.GD6190@tesla> (raw)
In-Reply-To: <1224579720.5521.2.camel@johannes.berg>
On Tue, Oct 21, 2008 at 02:02:00AM -0700, Johannes Berg wrote:
> the current documentation doesn't
> note that you need to free it on errors anyway.
Yes it does.
> /* Use this call to set the current regulatory domain. Conflicts with
> * multiple drivers can be ironed out later. Caller must've already
> - * kmalloc'd the rd structure. If this calls fails you should kfree()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
See?
> - * the passed rd. Caller must hold cfg80211_drv_mutex */
> + * kmalloc'd the rd structure. Caller must hold cfg80211_drv_mutex */
But this is fine too, so long as we keep the docs in sync.
Luis
next prev parent reply other threads:[~2008-10-22 18:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 9:02 [PATCH] wireless: fix regdom passing semantics Johannes Berg
2008-10-22 11:37 ` Luis R. Rodriguez [this message]
2008-10-22 18:47 ` Johannes Berg
2008-10-22 18:49 ` [PATCH v2] " Johannes Berg
2008-10-22 12:36 ` Luis R. Rodriguez
2008-10-22 19:40 ` Johannes Berg
2008-10-22 19:50 ` [PATCH v3] wireless: make regdom passing semantics simpler Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081022113751.GD6190@tesla \
--to=lrodriguez@atheros.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.