From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Date: Wed, 22 Oct 2008 13:52:48 +0200 Subject: [Ocfs2-devel] [PATCH] ocfs2: Fix checking of return value of new_inode() In-Reply-To: <20081021203503.GE2871@mail.oracle.com> References: <12245234434014-git-send-email-jack@suse.cz> <20081021203503.GE2871@mail.oracle.com> Message-ID: <20081022115248.GF13868@duck.suse.cz> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ocfs2-devel@oss.oracle.com On Tue 21-10-08 13:35:03, Joel Becker wrote: > On Mon, Oct 20, 2008 at 07:23:53PM +0200, Jan Kara wrote: > > new_inode() does not return ERR_PTR() but NULL in case of failure. Correct > > checking of the return value. > > > > Signed-off-by: Jan Kara > Signed-off-by: Joel Becker > > Another upstream candidate. Yep. Mark, will you pick it up or should I send you the patch directly? Honza > > > --- > > fs/ocfs2/namei.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c > > index d5d808f..0372ef0 100644 > > --- a/fs/ocfs2/namei.c > > +++ b/fs/ocfs2/namei.c > > @@ -382,8 +382,8 @@ static int ocfs2_mknod_locked(struct ocfs2_super *osb, > > } > > > > inode = new_inode(dir->i_sb); > > - if (IS_ERR(inode)) { > > - status = PTR_ERR(inode); > > + if (!inode) { > > + status = -ENOMEM; > > mlog(ML_ERROR, "new_inode failed!\n"); > > goto leave; > > } > > -- > > 1.5.2.4 > > > > > > _______________________________________________ > > Ocfs2-devel mailing list > > Ocfs2-devel at oss.oracle.com > > http://oss.oracle.com/mailman/listinfo/ocfs2-devel > > -- > > "Well-timed silence hath more eloquence than speech." > - Martin Fraquhar Tupper > > Joel Becker > Principal Software Developer > Oracle > E-mail: joel.becker at oracle.com > Phone: (650) 506-8127 -- Jan Kara SUSE Labs, CR