From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Dmitry Baryshkov <dbaryshkov@gmail.com>
Cc: linux-wireless@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] RFKILL: fix input layer initialisation
Date: Wed, 22 Oct 2008 15:15:02 -0200 [thread overview]
Message-ID: <20081022171502.GD1069@khazad-dum.debian.net> (raw)
In-Reply-To: <1224694375-29318-1-git-send-email-dbaryshkov@gmail.com>
On Wed, 22 Oct 2008, Dmitry Baryshkov wrote:
> Initialise correctly last fields, so tasks can be actually executed.
> On some architectures the initial jiffies value is not zero, so later
> all rfkill incorrectly decides that rfkill_*.last is in future.
>
> Signed-off-by: Dmitry Baryshkov <dbaryshkov@gmail.com>
> ---
> net/rfkill/rfkill-input.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/net/rfkill/rfkill-input.c b/net/rfkill/rfkill-input.c
> index e5b6955..cd93f48 100644
> --- a/net/rfkill/rfkill-input.c
> +++ b/net/rfkill/rfkill-input.c
> @@ -255,6 +255,11 @@ static struct input_handler rfkill_handler = {
>
> static int __init rfkill_handler_init(void)
> {
> + unsigned long last_run = jiffies - msecs_to_jiffies(500);
> + rfkill_wlan.last = last_run;
> + rfkill_bt.last = last_run;
> + rfkill_uwb.last = last_run;
> + rfkill_wimax.last = last_run;
> return input_register_handler(&rfkill_handler);
> }
This is not needed for wireless-testing's rfkill-input.
It is needed on 2.6.28, since AFAIK the stuff in wireless-testing is not
going to be sent for 2.6.28.
A similar patch to this was sent not a month ago, I think. One of the two
needs to be merged for 2.6.28.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2008-10-22 17:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 16:52 [PATCH] RFKILL: fix input layer initialisation Dmitry Baryshkov
2008-10-22 17:05 ` Ivo van Doorn
[not found] ` <200810221905.58169.IvDoorn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-10-28 12:33 ` Dmitry
2008-10-28 12:33 ` Dmitry
2008-10-22 17:15 ` Henrique de Moraes Holschuh [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-06-19 11:28 Dmitry Baryshkov
2008-06-19 18:49 ` Ivo van Doorn
2008-06-19 22:28 ` Dmitry
2008-06-20 19:23 ` Ivo van Doorn
2008-06-23 13:22 ` Dmitry Torokhov
2008-06-23 14:40 ` Dmitry Baryshkov
2008-06-23 15:24 ` Dmitry Torokhov
2008-06-23 18:21 ` Henrique de Moraes Holschuh
2008-06-23 18:25 ` Dmitry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081022171502.GD1069@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=dbaryshkov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.