From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Habkost Subject: Re: [PATCH 0/2] kvmtrace: Allow user to clean up stale trace setup Date: Wed, 22 Oct 2008 15:54:54 -0200 Message-ID: <20081022175454.GM27959@blackpad> References: <1224696928-22187-1-git-send-email-ehabkost@redhat.com> <5d6222a80810221042n44684c1fpdd5ea3f8cadb88db@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , kvm@vger.kernel.org To: Glauber Costa Return-path: Received: from mx2.redhat.com ([66.187.237.31]:46838 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753121AbYJVRzd (ORCPT ); Wed, 22 Oct 2008 13:55:33 -0400 Content-Disposition: inline In-Reply-To: <5d6222a80810221042n44684c1fpdd5ea3f8cadb88db@mail.gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Oct 22, 2008 at 03:42:27PM -0200, Glauber Costa wrote: > On Wed, Oct 22, 2008 at 3:35 PM, Eduardo Habkost wrote: > > If kvmtrace crashes or gets killed while collecting trace data, stale > > trace setup information may be enabled on the kernel, and currently > > there is no way to force the previous trace setup to be overwritten > > or disabled. > > > > The following two patches against kvm-userspace will add a new > > command-line option to kvmtrace (-f), that will allow the user to forcibly > > clean up an existing trace setup before enabling trace. > > Why can't we simply disable potential stale setups everytime, before we start? > The option would then not be needed Another kvmtrace instance may be already running. Do we want to kill its tracing setup without asking, by default? -- Eduardo