From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
Abhishek Sagar <sagar.abhishek@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Steven Rostedt <srostedt@redhat.com>
Subject: [PATCH 04/11] ftrace: comment arch ftrace code
Date: Wed, 22 Oct 2008 14:43:17 -0400 [thread overview]
Message-ID: <20081022185136.134729572@goodmis.org> (raw)
In-Reply-To: 20081022184313.179487464@goodmis.org
[-- Attachment #1: ftrace-comment-mod-code.patch --]
[-- Type: text/plain, Size: 1329 bytes --]
Add comments to explain what is happening in the x86 arch ftrace code.
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
arch/x86/kernel/ftrace.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
Index: linux-compile.git/arch/x86/kernel/ftrace.c
===================================================================
--- linux-compile.git.orig/arch/x86/kernel/ftrace.c 2008-10-22 13:15:36.000000000 -0400
+++ linux-compile.git/arch/x86/kernel/ftrace.c 2008-10-22 13:16:35.000000000 -0400
@@ -66,18 +66,23 @@ ftrace_modify_code(unsigned long ip, uns
/*
* Note: Due to modules and __init, code can
* disappear and change, we need to protect against faulting
- * as well as code changing.
+ * as well as code changing. We do this by using the
+ * __copy_*_user functions.
*
* No real locking needed, this code is run through
* kstop_machine, or before SMP starts.
*/
+
+ /* read the text we want to modify */
if (__copy_from_user_inatomic(replaced, (char __user *)ip,
MCOUNT_INSN_SIZE))
return -1;
+ /* Make sure it is what we expect it to be */
if (memcmp(replaced, old_code, MCOUNT_INSN_SIZE) != 0)
return -1;
+ /* replace the text with the new text */
if (__copy_to_user_inatomic((char __user *)ip, new_code,
MCOUNT_INSN_SIZE))
return -1;
--
next prev parent reply other threads:[~2008-10-22 18:52 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 18:43 [PATCH 00/11] ftrace: clean ups and fixes Steven Rostedt
2008-10-22 18:43 ` [PATCH 01/11] ftrace: handle generic arch calls Steven Rostedt
2008-10-22 18:56 ` Andrew Morton
2008-10-22 19:02 ` Steven Rostedt
2008-10-27 17:41 ` Steven Rostedt
2008-10-29 19:00 ` Sam Ravnborg
2008-10-29 19:14 ` Steven Rostedt
2008-10-29 19:24 ` Steven Rostedt
2008-10-29 19:49 ` Sam Ravnborg
2008-10-29 20:16 ` Adrian Bunk
2008-10-29 20:23 ` Steven Rostedt
2008-10-29 20:31 ` Adrian Bunk
2008-10-29 20:22 ` Adrian Bunk
2008-10-29 19:30 ` [PATCH] ftrace, kbuild: condense recordmcount.pl parameter code Steven Rostedt
2008-10-30 23:37 ` Ingo Molnar
2008-10-31 16:16 ` Sam Ravnborg
2008-10-22 18:43 ` [PATCH 02/11] ftrace: dynamic ftrace process only text section Steven Rostedt
2008-10-22 18:43 ` [PATCH 03/11] ftrace: return error on failed modified text Steven Rostedt
2008-10-22 18:55 ` Steven Rostedt
2008-10-22 18:57 ` Andrew Morton
2008-10-22 19:03 ` Steven Rostedt
2008-10-22 18:43 ` Steven Rostedt [this message]
2008-10-22 19:09 ` [PATCH 04/11] ftrace: comment arch ftrace code Andrew Morton
2008-10-22 19:16 ` Steven Rostedt
2008-10-22 19:26 ` Andrew Morton
2008-10-22 18:43 ` [PATCH 05/11] ftrace: only have ftrace_kill atomic Steven Rostedt
2008-10-22 19:11 ` Andrew Morton
2008-10-22 19:18 ` Steven Rostedt
2008-10-22 19:27 ` Andrew Morton
2008-10-22 18:43 ` [PATCH 06/11] ftrace: add ftrace warn on to disable ftrace Steven Rostedt
2008-10-22 19:12 ` Andrew Morton
2008-10-22 19:20 ` Steven Rostedt
2008-10-22 18:43 ` [PATCH 07/11] ftrace: do not trace init sections Steven Rostedt
2008-10-22 18:43 ` [PATCH 08/11] ftrace: disable dynamic ftrace for all archs that use daemon Steven Rostedt
2008-10-22 18:43 ` [PATCH 09/11] ftrace: remove daemon Steven Rostedt
2008-10-22 18:43 ` [PATCH 10/11] ftrace: remove mcount set Steven Rostedt
2008-10-22 18:43 ` [PATCH 11/11] ftrace: remove ftrace hash Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081022185136.134729572@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=sagar.abhishek@gmail.com \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.