Re: [PATCH] defined a macro for lemote 2e box IO base

[Thiemo Seufer <ths@networkno.de>]

Zhang Le wrote:
> ---
>  arch/mips/include/asm/lemote/pci.h |   31 +++++++++++++++++++++++++++++++
>  arch/mips/lemote/lm2e/setup.c      |    9 ++-------
>  2 files changed, 33 insertions(+), 7 deletions(-)
>  create mode 100644 arch/mips/include/asm/lemote/pci.h
> 
> diff --git a/arch/mips/include/asm/lemote/pci.h b/arch/mips/include/asm/lemote/pci.h
> new file mode 100644
> index 0000000..8e5c9c3
> --- /dev/null
> +++ b/arch/mips/include/asm/lemote/pci.h
> @@ -0,0 +1,31 @@
> +/*
> + * Copyright (c) 2008 Zhang Le <r0bertz@gentoo.org>
> + *
> + *     This program is free software; you can redistribute it
> + *     and/or modify it under the terms of the GNU General
> + *     Public License as published by the Free Software
> + *     Foundation; either version 2 of the License, or (at your
> + *     option) any later version.
> + *
> + *     This program is distributed in the hope that it will be
> + *     useful, but WITHOUT ANY WARRANTY; without even the implied
> + *     warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
> + *     PURPOSE.  See the GNU General Public License for more
> + *     details.
> + *
> + *     You should have received a copy of the GNU General Public
> + *     License along with this program; if not, write to the Free
> + *     Software Foundation, Inc., 675 Mass Ave, Cambridge, MA
> + *     02139, USA.
> + */
> +
> +#ifndef _LEMOTE_PCI_H_
> +#define _LEMOTE_PCI_H_
> +
> +#ifdef CONFIG_64BIT
> +#define LEMOTE_IO_PORT_BASE 0xffffffffbfd00000
> +#else
> +#define LEMOTE_IO_PORT_BASE 0xbfd00000
> +#endif

Why not "((const long)0xbfd00000)" instead? AFAICS it is never used in
assembly code.


Thiemo