From: David Miller <davem@davemloft.net>
To: jesse.brandeburg@intel.com
Cc: avillaci@ceibo.fiec.espol.edu.ec,
irda-users@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: Regression: Recent networking (qdisc?) patches break irda_get_next_speed()
Date: Thu, 23 Oct 2008 17:21:29 -0700 (PDT) [thread overview]
Message-ID: <20081023.172129.179937745.davem@davemloft.net> (raw)
In-Reply-To: <F169D4F5E1F1974DBFAFABF47F60C10A069DFD1F@orsmsx507.amr.corp.intel.com>
From: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
Date: Thu, 23 Oct 2008 15:13:02 -0700
> Isn't this what the data that is skb_reserve'd at the beginning of
> skb's allocated by netdev_alloc_skb is for? If you take an extra
> reference to the skb and/or use a destructor hook you should be
> good, right?
>
> you should just be able to push ->data using skb_reserve(sizeof your
> private data) in the beginning of the skb, or is that a horrible
> idea Dave?
This area of the SKB data is still volatile.
Let's say a packet scheduler classifier causes a TC action
to execute which pushes stuff there, it'll get overwritten.
Really, this idea won't work.
prev parent reply other threads:[~2008-10-24 0:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 18:20 Regression: Recent networking (qdisc?) patches break irda_get_next_speed() Alex Villacís Lasso
2008-10-21 19:37 ` Jarek Poplawski
2008-10-21 23:37 ` Alex Villacís Lasso
2008-10-21 23:41 ` David Miller
[not found] ` <20081021.164121.257737412.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-10-23 0:24 ` Alex Villacís Lasso
2008-10-23 22:13 ` Brandeburg, Jesse
2008-10-23 23:16 ` Stephen Hemminger
2008-10-24 0:21 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081023.172129.179937745.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=avillaci@ceibo.fiec.espol.edu.ec \
--cc=irda-users@lists.sourceforge.net \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.