From: David Brownell <david-b@pacbell.net>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/5] OMAP242x omapdev: add OMAP242x omapdev records
Date: Thu, 23 Oct 2008 00:34:25 -0700 [thread overview]
Message-ID: <200810230034.26002.david-b@pacbell.net> (raw)
In-Reply-To: <20081018215910.9699.13379.stgit@localhost.localdomain>
On Saturday 18 October 2008, Paul Walmsley wrote:
> --- a/arch/arm/mach-omap2/omapdev-common.h
> +++ b/arch/arm/mach-omap2/omapdev-common.h
> @@ -21,6 +21,87 @@
> #include "omapdev3xxx.h"
>
> static struct omapdev *omapdevs[] = {
> +
> +#ifdef CONFIG_ARCH_OMAP2420
> + &mpu_242x_omapdev,
> + &iva_242x_omapdev,
> + &gfx_242x_omapdev,
> ...
Urgh, this is unpleasant style: declaration of a large
static data structure in a header file.
Cleaner: just have some omap2420-specific C file declare
the struct, and hand it off to whatever code uses it.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-10-23 9:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-18 21:59 [PATCH 0/5] PM: add omapdev code Paul Walmsley
2008-10-18 21:59 ` [PATCH 1/5] OMAP2/3 omapdev: add basic omapdev structure Paul Walmsley
2008-10-23 7:26 ` David Brownell
2008-10-18 21:59 ` [PATCH 2/5] OMAP242x omapdev: add OMAP242x omapdev records Paul Walmsley
2008-10-23 7:34 ` David Brownell [this message]
2008-12-11 3:55 ` Paul Walmsley
2008-12-11 8:10 ` Felipe Balbi
2008-10-18 21:59 ` [PATCH 3/5] OMAP243x omapdev: add OMAP243x " Paul Walmsley
2008-10-18 21:59 ` [PATCH 4/5] OMAP3xxx omapdev: add OMAP3xxx " Paul Walmsley
2008-10-18 21:59 ` [PATCH 5/5] OMAP2/3 omapdev: add code to walk the " Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810230034.26002.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.