From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH] tracing: fix a build error on alpha and m68k Date: Thu, 23 Oct 2008 18:55:04 +0200 Message-ID: <20081023165504.GB25697@elte.hu> References: <49008D12.5090204@gmail.com> <4900B414.7090002@gmail.com> <20081023163433.GA3160@x200.localdomain> <20081023163850.GB16591@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mx3.mail.elte.hu ([157.181.1.138]:48076 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753653AbYJWQzY (ORCPT ); Thu, 23 Oct 2008 12:55:24 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-next-owner@vger.kernel.org List-ID: To: =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker Cc: Alexey Dobriyan , Geert Uytterhoeven , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Steven Rostedt * Fr=E9d=E9ric Weisbecker wrote: > But they should be able to use the tracing for several other tracers.= =20 > One other problem is that you need CONFIG_TRACE_IRQFLAGS (is that a=20 > lockdep or just trace feature?) to use any tracer since the=20 > tracing_cpumask file is always created for all tracer. This file has=20 > tracing_cpumask_write() as a write operation, and this func uses=20 > raw_local_funcs.... >=20 > Perhaps we should disable the tracing_cpu_mask related things if=20 > TRACE_IRQFLAGS in not configured? to answer the "is that a lockdep or just trace feature" question: trace-irqflags was first written by me for the (crude) ftrace-precursor= =20 latency tracer code in -rt, years ago. Then i reused it (and changed it= =20 alot) for upstream lockdep, two years ago. Then ftrace came in this yea= r=20 and reused it. so it's rather symbiotic ;-) So ... the tracers that rely on irqflags-tracing should definitely be=20 limited to architectures that provide TRACE_IRQFLAGS. The core trace.c=20 itself should probably not be restricted ... (and it should definitely=20 build) Ingo