From: David Brownell <david-b@pacbell.net>
To: Jarkko Nikula <jarkko.nikula@nokia.com>
Cc: linux-omap@vger.kernel.org, marek.vasut@gmail.com
Subject: Re: [patch 2.6.27-omap-git 3/4] remove omap_set_gpio_direction()
Date: Fri, 24 Oct 2008 00:52:35 -0700 [thread overview]
Message-ID: <200810240052.35896.david-b@pacbell.net> (raw)
In-Reply-To: <20081024100031.0d5a1db5.jarkko.nikula@nokia.com>
On Friday 24 October 2008, Jarkko Nikula wrote:
> > drivers/leds/leds-omap.c | 2 +-
> >
> IMO this driver should go and board-palmtt.c to use
> drivers/leds/leds-gpio.c instead.
I second that. There's no need for leds-omap.c ...
In a similar vein, drivers/leds/leds-omap-pwm.c seems like
it should be able to use led_classdev.blink_set(), or maybe
fit into that newish PWM framework being discussed. (Not
that it has PWM controlled led *blinking* yet ...)
The PWM support can likely wait a while though, unless
someone's keen on getting that part of n800 support upstream
sooner rather than later.
- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-10-24 7:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 6:56 [patch 2.6.27-omap-git 3/4] remove omap_set_gpio_direction() David Brownell
2008-10-24 7:00 ` Jarkko Nikula
2008-10-24 7:52 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810240052.35896.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=jarkko.nikula@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=marek.vasut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.