From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH 3/2] delalloc support for xfs fiemap
Date: Fri, 24 Oct 2008 16:29:30 +1100 [thread overview]
Message-ID: <20081024052930.GI18495@disturbed> (raw)
In-Reply-To: <49014887.6050309@sandeen.net>
On Thu, Oct 23, 2008 at 11:01:11PM -0500, Eric Sandeen wrote:
> Ok, got the kinks worked out of the delalloc portion of the
> fiemap hookup I think.
>
> This introduces a new input flag (BMV_IF_DELALLOC) and output
> flag (BMV_OF_DELALLOC) to request & show the delayed allocation
> segments.
....
> @@ -5827,6 +5827,7 @@ xfs_getbmap(
> * preallocated data space */
> int sh_unwritten; /* true, if unwritten */
> /* extents listed separately */
> + int sh_delalloc; /* show delayed extents */
> int iflags; /* interface flags */
> int bmapi_flags; /* flags for xfs_bmapi */
Do we really need this "sh_delalloc" flag? Checking for
(iflags & BMV_IF_DELALLOC) is fine by me, same for replacing
sh_unwritten. I've never really liked the "sh" abbreviation for
"show"....
Otherwise it looks ok. Perhaps we should also add delalloc extent
display to xfs_bmap....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-10-24 5:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 4:01 [PATCH 3/2] delalloc support for xfs fiemap Eric Sandeen
2008-10-24 5:29 ` Dave Chinner [this message]
2008-10-24 13:01 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081024052930.GI18495@disturbed \
--to=david@fromorbit.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.