From: Stephen Hemminger <shemminger@vyatta.com>
To: Robert Fitzsimons <robfitz@273k.net>
Cc: Manfred Scherer <manfred.scherer.mhm@t-online.de>,
Michal Ostrowski <mostrows@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
netdev@vger.kernel.org, bugme-daemon@bugzilla.kernel.org,
Robert Fitzsimons <robfitz@273k.net>
Subject: Re: [Bugme-new] [Bug 11754] New: tlan network driver does not work
Date: Fri, 24 Oct 2008 17:18:35 -0700 [thread overview]
Message-ID: <20081024171835.424b75d3@extreme> (raw)
In-Reply-To: <20081025000033.GA2967@localhost>
On Sat, 25 Oct 2008 01:00:33 +0100
Robert Fitzsimons <robfitz@273k.net> wrote:
> I've double checked my patch and still think it's correct. Lets quickly
> review it:
>
> @@ -360,8 +360,8 @@ TLan_GetSKB( const struct tlan_list_tag *tag)
> {
> unsigned long addr;
>
> - addr = tag->buffer[8].address;
> - addr |= (tag->buffer[9].address << 16) << 16;
> + addr = tag->buffer[9].address;
> + addr |= (tag->buffer[8].address << 16) << 16;
There is upper_32_bits(x) and lower_32_bits(x) for this (see kernel.h)
next prev parent reply other threads:[~2008-10-25 0:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-11754-10286@http.bugzilla.kernel.org/>
2008-10-14 12:32 ` [Bugme-new] [Bug 11754] New: tlan network driver does not work Andrew Morton
2008-10-14 11:16 ` Manfred Scherer
[not found] ` <200810210836.18765.manfred.scherer.mhm@t-online.de>
[not found] ` <e6d1cecd0810210843pfaa2d46h66b05a63398b2e03@mail.gmail.com>
2008-10-21 14:34 ` Manfred Scherer
[not found] ` <e6d1cecd0810211540l7182c270l88de14cf18cfcd50@mail.gmail.com>
2008-10-24 4:12 ` Manfred Scherer
2008-10-25 0:00 ` Robert Fitzsimons
2008-10-25 0:18 ` Stephen Hemminger [this message]
[not found] <1229384410-16879-1-git-send-email-sakari.ailus@iki.fi>
2008-12-16 9:13 ` Manfred Scherer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081024171835.424b75d3@extreme \
--to=shemminger@vyatta.com \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=manfred.scherer.mhm@t-online.de \
--cc=mostrows@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=robfitz@273k.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.