From: Tony Lindgren <tony@atomide.com>
To: David Brownell <david-b@pacbell.net>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] alsa: add beagleboard SoC configuration.
Date: Fri, 24 Oct 2008 12:03:38 -0700 [thread overview]
Message-ID: <20081024190338.GE16354@atomide.com> (raw)
In-Reply-To: <200810221209.28194.david-b@pacbell.net>
* David Brownell <david-b@pacbell.net> [081022 12:14]:
> On Wednesday 22 October 2008, Felipe Contreras wrote:
> > +
> > + printk(KERN_INFO "OMAP3 Beagle SoC init\n");
> > + if (!machine_is_omap3_beagle()) {
> > + printk(KERN_ERR "Not OMAP3 Beagle!\n");
> > + return -ENODEV;
> > + }
> > +
>
> Note that the version I (re)posted fixed the bogus messaging
> on non-Beagle boards. Move that KERN_INFO after the "if ...)".
> And for that matter, the KERN_ERR isn't really an error; it's
> quite legit to have a kernel support e.g. both Overo and Beagle.
OK, will push Dave's fixed version.
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-10-24 19:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 16:28 [PATCH] alsa: add beagleboard SoC configuration Felipe Contreras
2008-10-22 16:53 ` Tony Lindgren
2008-10-22 19:36 ` David Brownell
2008-10-22 20:30 ` Steve Sakoman
2008-10-22 20:44 ` Mark Brown
2008-10-30 11:45 ` Mark Brown
2008-10-30 13:14 ` Steve Sakoman
2008-10-22 19:09 ` David Brownell
2008-10-24 19:03 ` Tony Lindgren [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-09-16 20:51 [PATCH] alsa: add Beagleboard " Felipe Contreras
2008-09-17 6:19 ` Jarkko Nikula
2008-09-17 12:15 ` Steve Sakoman
2008-10-04 6:34 ` David Brownell
2008-10-06 15:09 ` Paul Walmsley
2008-10-06 18:01 ` David Brownell
2008-10-06 18:32 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081024190338.GE16354@atomide.com \
--to=tony@atomide.com \
--cc=david-b@pacbell.net \
--cc=felipe.contreras@gmail.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.