All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Cc: Ingo Molnar <mingo@elte.hu>, Mike Travis <travis@sgi.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -tip/cpus4096-v2] cpumask: fix memory leak and cpumask corruption
Date: Fri, 24 Oct 2008 19:55:29 +1100	[thread overview]
Message-ID: <200810241955.29400.rusty@rustcorp.com.au> (raw)
In-Reply-To: <4901564F.7020308@ct.jp.nec.com>

On Friday 24 October 2008 15:59:59 Hiroshi Shimamoto wrote:
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>

Hi Hiroshi,

   Thanks for looking at this!

> On CONFIG_CPUMASK_OFFSTACK enabled kernel, when exiting
> smp_call_function_many() without calling arch_send_call_function_ipi()
> allbutself should be freed.

   That bit's OK, changing the return to "goto out;".

> Also, the memory for allbutself shouldn't be freed when
> arch_send_call_function_ipi() is called.  The memory region will be
> referenced in generic_smp_call_function_interrupt(). And the memory
> will be freed at rcu_free_call_data().

As your next patch shows, this should be solved a different way.  I'll comment 
there.

Cheers,
Rusty.

      reply	other threads:[~2008-10-24  8:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-24  4:59 [PATCH -tip/cpus4096-v2] cpumask: fix memory leak and cpumask corruption Hiroshi Shimamoto
2008-10-24  8:55 ` Rusty Russell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810241955.29400.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=h-shimamoto@ct.jp.nec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=travis@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.