From: Ben Hutchings <bhutchings@solarflare.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
Benjamin Li <benli@broadcom.com>,
netdev@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: PCI VPD size
Date: Fri, 24 Oct 2008 21:52:48 +0100 [thread overview]
Message-ID: <20081024205246.GR7331@solarflare.com> (raw)
In-Reply-To: <20081024125035.4ebad408@extreme>
Stephen Hemminger wrote:
> Why did you choose to limit VPD access by using PCI quirks:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=99cb233d60cbe644203f19938c729ea2bb004d70
>
> Rather than controlling size in the device driver which is what my
> patches (which seem to have been ignored) did:
> http://marc.info/?l=linux-netdev&m=122393195716363&w=2
>
> The problem with the quirk scheme is that it means putting more
> per device settings in a location farther away in the source code
> than the underlying device driver.
The limit needs to be set in quirks because VPD I/O beyond that limit
causes those devices to stop responding. If I understand correctly,
you're only reducing the limit as an optimisation.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2008-10-24 20:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 19:50 PCI VPD size Stephen Hemminger
2008-10-24 20:52 ` Ben Hutchings [this message]
2008-10-24 21:18 ` Jesse Barnes
2008-10-24 21:24 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081024205246.GR7331@solarflare.com \
--to=bhutchings@solarflare.com \
--cc=benli@broadcom.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.