From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: Fix check of return value of ocfs2_start_trans()
Date: Fri, 24 Oct 2008 14:41:42 -0700 [thread overview]
Message-ID: <20081024214142.GC9302@mail.oracle.com> (raw)
In-Reply-To: <20081021202618.GC2871@mail.oracle.com>
On Tue, Oct 21, 2008 at 01:26:18PM -0700, Joel Becker wrote:
> On Mon, Oct 20, 2008 at 07:23:51PM +0200, Jan Kara wrote:
> > On failure, ocfs2_start_trans() returns values like ERR_PTR(-ENOMEM).
> > Thus checks for !handle are wrong. Fix them to use IS_ERR().
> >
> > Signed-off-by: Jan Kara <jack@suse.cz>
> Signed-off-by: Joel Becker <joel.becker@oracle.com>
>
> This should go upstream. There are two more in xattr.c (not in the
> sources Jan had).
This is now in my xattr-28 branch, along with Tao's version for
xattr.c
Joel
--
Pitchers and catchers report.
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
prev parent reply other threads:[~2008-10-24 21:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 17:23 [Ocfs2-devel] [PATCH] ocfs2: Fix check of return value of ocfs2_start_trans() Jan Kara
2008-10-21 20:26 ` Joel Becker
2008-10-22 10:07 ` Jan Kara
2008-10-24 21:41 ` Joel Becker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081024214142.GC9302@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.