[PATCH] p54: fix build warnings

[Christian Lamparter <chunkeey@web.de>]

On Saturday 25 October 2008 10:24:10 Johannes Berg wrote:
> just FYI in case you haven't seen them. the p54 one looks like a genu=
ine
> problem.
>
> drivers/net/wireless/p54/p54common.c: In function =E2=80=98p54_parse_=
eeprom=E2=80=99:
> drivers/net/wireless/p54/p54common.c:325: warning: =E2=80=98synth=E2=80=
=99 may be used uninitialized in this function

There you go. Yes, it is a genuine problem, if the device's eeprom is s=
crewed really up.

Signed-off-by: Christian Lamparter <chunkeey@web.de>
---
diff --git a/drivers/net/wireless/p54/p54common.c b/drivers/net/wireles=
s/p54/p54common.c
index 360f35b..02a306d 100644
--- a/drivers/net/wireless/p54/p54common.c
+++ b/drivers/net/wireless/p54/p54common.c
@@ -322,7 +322,7 @@ static int p54_parse_eeprom(struct ieee80211_hw *de=
v, void *eeprom, int len)
 	void *tmp;
 	int err;
 	u8 *end =3D (u8 *)eeprom + len;
-	u16 synth;
+	u16 synth =3D 0;
 	DECLARE_MAC_BUF(mac);
=20
 	wrap =3D (struct eeprom_pda_wrap *) eeprom;
@@ -425,7 +425,8 @@ static int p54_parse_eeprom(struct ieee80211_hw *de=
v, void *eeprom, int len)
 		entry =3D (void *)entry + (entry_len + 1)*2;
 	}
=20
-	if (!priv->iq_autocal || !priv->output_limit || !priv->curve_data) {
+	if (!synth || !priv->iq_autocal || !priv->output_limit ||
+	    !priv->curve_data) {
 		printk(KERN_ERR "p54: not all required entries found in eeprom!\n");
 		err =3D -EINVAL;
 		goto err;
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html