From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Christoph Hellwig <hch@infradead.org>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: fix nr of args in open calls
Date: Sat, 25 Oct 2008 16:22:32 -0400 [thread overview]
Message-ID: <20081025202232.GE28002@infradead.org> (raw)
In-Reply-To: <49037F3C.6030007@sandeen.net>
On Sat, Oct 25, 2008 at 03:19:08PM -0500, Eric Sandeen wrote:
> Christoph Hellwig wrote:
> > On Sat, Oct 25, 2008 at 01:45:53PM -0500, Eric Sandeen wrote:
> >> --- xfstests.orig/ltp/iogen.c
> >> +++ xfstests/ltp/iogen.c
> >> @@ -1060,7 +1060,11 @@ int nbytes;
> >>
> >> Oflags |= O_CREAT | O_WRONLY;
> >>
> >> +#ifdef CRAY
> >> if ((fd = open(path, Oflags, 0666, Ocbits, Ocblks)) == -1) {
> >> +#else
> >> + if ((fd = open(path, Oflags, 0666)) == -1) {
> >> +#endif
> >
> > Do we really need that ifdef cray here?
>
> Not sure; Ocbits etc are set under the same #ifdef, xfsqa runs on irix,
> and I'm not sure what all gets set on that build ...
#ifdef CRAY is for Unicos, and I don't think xfsqa near it's current
version can run there. I'd rather see all this striped out, but at
least no new occurances added.
next prev parent reply other threads:[~2008-10-25 20:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-25 18:45 [PATCH] xfstests: fix nr of args in open calls Eric Sandeen
2008-10-25 20:17 ` Christoph Hellwig
2008-10-25 20:19 ` Eric Sandeen
2008-10-25 20:22 ` Christoph Hellwig [this message]
2008-10-26 3:45 ` [PATCH V2] " Eric Sandeen
2008-11-12 9:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081025202232.GE28002@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.