From: Jeff King <peff@peff.net>
To: Thomas Rast <trast@student.ethz.ch>
Cc: git@vger.kernel.org, Junio C Hamano <junio@pobox.com>
Subject: Re: [PATCH] add -p: warn if only binary changes present
Date: Sun, 26 Oct 2008 01:10:13 -0400 [thread overview]
Message-ID: <20081026051013.GD21178@coredump.intra.peff.net> (raw)
In-Reply-To: <1224884916-20369-1-git-send-email-trast@student.ethz.ch>
On Fri, Oct 24, 2008 at 11:48:36PM +0200, Thomas Rast wrote:
> Current 'git add -p' will say "No changes." if there are no changes to
> text files, which can be confusing if there _are_ changes to binary
> files. Add some code to distinguish the two cases, and give a
> different message in the latter one.
Having just looked at this code (for potentially handling "git add -p"
of new files), I think this change is sane.
> + print STDERR "No changes except to binary files.\n";
This wording seems a little awkward to me, though. Maybe
No changed text files.
?
-Peff
next prev parent reply other threads:[~2008-10-26 5:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 21:48 [PATCH] add -p: warn if only binary changes present Thomas Rast
2008-10-26 5:10 ` Jeff King [this message]
2008-10-26 10:28 ` Thomas Rast
2008-10-26 10:40 ` SZEDER Gábor
2008-10-26 19:37 ` [PATCH v2] " Thomas Rast
2008-10-26 19:38 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081026051013.GD21178@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=junio@pobox.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.