All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	Roman Zippel <zippel@linux-m68k.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] fix allmodconfig breakage
Date: Sun, 26 Oct 2008 05:12:34 +0000	[thread overview]
Message-ID: <20081026051234.GN28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20081025211107.GA20417@uranus.ravnborg.org>

	If you use KCONFIG_ALLCONFIG (even with empty file) you get
broken allmodconfig/allyesconfig; CONFIG_MODULES gets turned off,
with obvious massive fallout.

	Breakage had been introduced when conf_set_all_new_symbols()
got used for allmodconfig et.al.

	What happens is that sym_calc_value(modules_sym) done in
conf_read_simple() sets SYMBOL_VALID on both modules_sym and MODULES.
When we get to conf_set_all_new_symbols(), we set sym->def[S_DEF_USER]
on everything, but it has no effect on sym->curr for the symbols that
already have SYMBOL_VALID - these are stuck.

	Solution: use sym_clear_all_valid() in there.  Note that it
makes reevaluation of modules_sym redundant - sym_clear_all_valid()
will do that itself.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index b91cf24..830d9ea 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -852,8 +852,7 @@ void conf_set_all_new_symbols(enum conf_def_mode mode)
 
 	}
 
-	if (modules_sym)
-		sym_calc_value(modules_sym);
+	sym_clear_all_valid();
 
 	if (mode != def_random)
 		return;

  parent reply	other threads:[~2008-10-26  5:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-25 21:11 [PULL] kbuild fixes for -rc1 Sam Ravnborg
2008-10-25 21:59 ` kbuild maintainer news [Was: kbuild fixes for -rc1] Sam Ravnborg
2008-10-26  1:06   ` Frans Pop
2008-10-26  5:12 ` Al Viro [this message]
2008-10-26  5:32   ` [PATCH] fix allmodconfig breakage Alexey Dobriyan
2008-10-27 14:40   ` Roman Zippel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081026051234.GN28946@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=torvalds@linux-foundation.org \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.