From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] wire up ->open for directories
Date: Mon, 27 Oct 2008 12:20:08 +1100 [thread overview]
Message-ID: <20081027012008.GD11948@disturbed> (raw)
In-Reply-To: <20081026203437.GB4173@infradead.org>
On Sun, Oct 26, 2008 at 04:34:37PM -0400, Christoph Hellwig wrote:
> Currently there's no ->open method set for directories on XFS. That
> means we don't perform any check for opening too large directories
> without O_LARGEFILE, we don't check for shut down filesystems, and we
> don't actually do the readahead for the first block in the directory.
>
> Instead of just setting the directories open routine to xfs_file_open
> we merge the shutdown check directly into xfs_file_open and create
> a new xfs_dir_open that first calls xfs_file_open and then performs
> the readahead for block 0.
Looks good to me.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-10-27 1:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-26 20:34 [PATCH 1/2] wire up ->open for directories Christoph Hellwig
2008-10-27 1:20 ` Dave Chinner [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-10-27 13:30 Christoph Hellwig
2008-10-27 23:36 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081027012008.GD11948@disturbed \
--to=david@fromorbit.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.