From: Jean Delvare <khali@linux-fr.org>
To: "Eric Miao" <ymiao3@marvell.com>
Cc: "Mike Rapoport" <mike@compulab.co.il>,
"Richard Purdie" <rpurdie@linux.intel.com>,
"LKML" <linux-kernel@vger.kernel.org>,
"Linus Torvalds" <torvalds@linux-foundation.org>
Subject: Re: CONFIG_LEDS_DA903X=m breaks 2.6.28-rc2-git1 build on x86-64
Date: Mon, 27 Oct 2008 12:42:08 +0100 [thread overview]
Message-ID: <20081027124208.72adeae2@hyperion.delvare> (raw)
In-Reply-To: <E913911567467945BBEB9277E27868B0013A5EEA@msiexch01.marvell.com>
Hi Eric,
On Mon, 27 Oct 2008 03:09:25 -0700, Eric Miao wrote:
> This is strange, it compiles OK on ARM, I don't know why this
> failed on x86-64. But anyway, <linux/workqueue.h> should really
> be explicitly included here.
>
> The attached patch should fix this.
Yes it does, thanks for the quick fix. Please get this upstream quickly
too.
Acked-by: Jean Delvare <khali@linux-fr.org>
--
Jean Delvare
prev parent reply other threads:[~2008-10-27 11:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-27 8:45 CONFIG_LEDS_DA903X=m breaks 2.6.28-rc2-git1 build on x86-64 Jean Delvare
2008-10-27 10:09 ` Eric Miao
2008-10-27 11:42 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081027124208.72adeae2@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike@compulab.co.il \
--cc=rpurdie@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=ymiao3@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.