From: David Brownell <david-b@pacbell.net>
To: Alessandro Zummo <alessandro.zummo@towertech.it>
Cc: rtc-linux@googlegroups.com, broonie@opensource.wolfsonmicro.com,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [rtc-linux] [PATCH 2/2] rtc: rtc-wm8350: Add support for WM8350 RTC
Date: Mon, 27 Oct 2008 13:03:21 -0700 [thread overview]
Message-ID: <200810271303.21634.david-b@pacbell.net> (raw)
In-Reply-To: <20081027180432.7deaee0a@i1501.lan.towertech.it>
On Monday 27 October 2008, Alessandro Zummo wrote:
> (and a detailed checklist at http://groups.google.com/group/rtc-linux/web/checklist )
The comment about probe()/__devinit and remove()/__devexit/__devexit_p
isn't right ... when the driver uses platform_driver_probe(), the "__dev"
variants should not be used. (It's a Good Thing to shrink runtime code
footprints, by using platform_driver_probe for non-hotpluggable devices.)
Also: rtc_ops.ioctl() method should only handle RTC_{AIE,UIE}_{ON,OFF},
since the other standard ioctls have rtc_ops equivalents.
(This code is fine in both respects. Though since I've received three
copies of the driver since it was merged to MM, maybe I missed something.)
- Dave
next prev parent reply other threads:[~2008-10-27 20:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-27 15:38 [PATCH 1/2] rtc: Fix handling of missing tm_year data when reading alarms Mark Brown
2008-10-27 15:38 ` [PATCH 2/2] rtc: rtc-wm8350: Add support for WM8350 RTC Mark Brown
2008-10-27 17:04 ` [rtc-linux] " Alessandro Zummo
2008-10-27 17:24 ` [rtc-linux] " Mark Brown
2008-10-27 17:26 ` Alessandro Zummo
2008-10-27 17:40 ` Mark Brown
2008-10-28 6:24 ` Andrew Morton
2008-10-27 20:03 ` David Brownell [this message]
2008-10-27 20:09 ` [rtc-linux] " Mark Brown
2008-10-27 20:19 ` David Brownell
2008-10-28 6:22 ` Andrew Morton
2008-10-28 10:02 ` Mark Brown
2008-10-27 16:51 ` [PATCH 1/2] rtc: Fix handling of missing tm_year data when reading alarms Alessandro Zummo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810271303.21634.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@linux-foundation.org \
--cc=alessandro.zummo@towertech.it \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.