diff for duplicates of <20081028002718.GA2992@kroah.com> diff --git a/a/1.txt b/N1/1.txt index d1d1c8c..ae0fdd3 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,35 +1,28 @@ On Mon, Oct 27, 2008 at 05:15:53PM -0400, John W. Linville wrote: > On Mon, Oct 27, 2008 at 11:56:34AM -0700, Greg KH wrote: > > On Fri, Oct 24, 2008 at 03:48:59PM -0400, John W. Linville wrote: -> > > This updates drivers/staging/at76_usb to correspond with the late= -st +> > > This updates drivers/staging/at76_usb to correspond with the latest > > > version previously available in wireless-testing. -> > >=20 +> > > > > > Signed-off-by: John W. Linville <linville@tuxdriver.com> -> >=20 -> > I've applied this, but it does add the following warnings, which I = -don't +> > +> > I've applied this, but it does add the following warnings, which I don't > > think you want to have: -> > drivers/staging/at76_usb/at76_usb.c:885: warning: =E2=80=98at76_se= -t_associd=E2=80=99 defined but not used -> > drivers/staging/at76_usb/at76_usb.c:903: warning: =E2=80=98at76_se= -t_listen_interval=E2=80=99 defined but not used -> > drivers/staging/at76_usb/at76_usb.c:989: warning: =E2=80=98at76_ad= -d_mac_address=E2=80=99 defined but not used -> >=20 -> >=20 +> > drivers/staging/at76_usb/at76_usb.c:885: warning: ‘at76_set_associd’ defined but not used +> > drivers/staging/at76_usb/at76_usb.c:903: warning: ‘at76_set_listen_interval’ defined but not used +> > drivers/staging/at76_usb/at76_usb.c:989: warning: ‘at76_add_mac_address’ defined but not used +> > +> > > > I'll remove these unused functions now from the in-kernel version. ->=20 -> Those were still there because Kalle had said he intended to use them= -=2E +> +> Those were still there because Kalle had said he intended to use them. > I see no need to carry them since you have them in git anyway. Heh, fine, they are now gone, we can't add patches that add warnings :) -> > Is there any way to do development on this in the staging version n= -ow, +> > Is there any way to do development on this in the staging version now, > > instead of the wireless-testing tree? ->=20 +> > Fine with me, although I do have at least one patch for it that > relates to a pending API change -- I just figured I'd wait for the > round-trip of the patch above and then carry just that patch in my @@ -37,16 +30,10 @@ ow, > development makes sense to go to your tree. How about just sending that patch in when the api change goes in. I -have no problem with other people sending in patches through their tree= -s +have no problem with other people sending in patches through their trees that touch the staging directory for stuff like this, as it makes your life much easier. thanks, greg k-h --- -To unsubscribe from this list: send the line "unsubscribe linux-wireles= -s" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index db2e606..4106cd9 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -13,35 +13,28 @@ "On Mon, Oct 27, 2008 at 05:15:53PM -0400, John W. Linville wrote:\n" "> On Mon, Oct 27, 2008 at 11:56:34AM -0700, Greg KH wrote:\n" "> > On Fri, Oct 24, 2008 at 03:48:59PM -0400, John W. Linville wrote:\n" - "> > > This updates drivers/staging/at76_usb to correspond with the late=\n" - "st\n" + "> > > This updates drivers/staging/at76_usb to correspond with the latest\n" "> > > version previously available in wireless-testing.\n" - "> > >=20\n" + "> > > \n" "> > > Signed-off-by: John W. Linville <linville@tuxdriver.com>\n" - "> >=20\n" - "> > I've applied this, but it does add the following warnings, which I =\n" - "don't\n" + "> > \n" + "> > I've applied this, but it does add the following warnings, which I don't\n" "> > think you want to have:\n" - "> > \tdrivers/staging/at76_usb/at76_usb.c:885: warning: =E2=80=98at76_se=\n" - "t_associd=E2=80=99 defined but not used\n" - "> > \tdrivers/staging/at76_usb/at76_usb.c:903: warning: =E2=80=98at76_se=\n" - "t_listen_interval=E2=80=99 defined but not used\n" - "> > \tdrivers/staging/at76_usb/at76_usb.c:989: warning: =E2=80=98at76_ad=\n" - "d_mac_address=E2=80=99 defined but not used\n" - "> >=20\n" - "> >=20\n" + "> > \tdrivers/staging/at76_usb/at76_usb.c:885: warning: \342\200\230at76_set_associd\342\200\231 defined but not used\n" + "> > \tdrivers/staging/at76_usb/at76_usb.c:903: warning: \342\200\230at76_set_listen_interval\342\200\231 defined but not used\n" + "> > \tdrivers/staging/at76_usb/at76_usb.c:989: warning: \342\200\230at76_add_mac_address\342\200\231 defined but not used\n" + "> > \n" + "> > \n" "> > I'll remove these unused functions now from the in-kernel version.\n" - ">=20\n" - "> Those were still there because Kalle had said he intended to use them=\n" - "=2E\n" + "> \n" + "> Those were still there because Kalle had said he intended to use them.\n" "> I see no need to carry them since you have them in git anyway.\n" "\n" "Heh, fine, they are now gone, we can't add patches that add warnings :)\n" "\n" - "> > Is there any way to do development on this in the staging version n=\n" - "ow,\n" + "> > Is there any way to do development on this in the staging version now,\n" "> > instead of the wireless-testing tree?\n" - ">=20\n" + "> \n" "> Fine with me, although I do have at least one patch for it that\n" "> relates to a pending API change -- I just figured I'd wait for the\n" "> round-trip of the patch above and then carry just that patch in my\n" @@ -49,18 +42,12 @@ "> development makes sense to go to your tree.\n" "\n" "How about just sending that patch in when the api change goes in. I\n" - "have no problem with other people sending in patches through their tree=\n" - "s\n" + "have no problem with other people sending in patches through their trees\n" "that touch the staging directory for stuff like this, as it makes your\n" "life much easier.\n" "\n" "thanks,\n" "\n" - "greg k-h\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-wireles=\n" - "s\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + greg k-h -784e0af7169a225ea5c209d943c56ca0028f3f63952138dbc1b2276d0fb6436a +98a3461d7776d9162b3d0acbd509c61289c3d8b2072ec3e3de32dc3f828ccad8
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.