All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Heidelberg <markus.heidelberg@web.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] qtopia4: fix use of pkg-config
Date: Tue, 28 Oct 2008 09:22:53 +0100	[thread overview]
Message-ID: <200810280922.53728.markus.heidelberg@web.de> (raw)
In-Reply-To: <20081028081410.5395e6f0@surf>

Thomas Petazzoni, 28.10.2008:
> Le Tue, 28 Oct 2008 02:51:36 +0100,
> Markus Heidelberg <markus.heidelberg@web.de> a ?crit :
> 
> > +		$(TARGET_CONFIGURE_OPTS) \
> > +		PKG_CONFIG_SYSROOT="$(STAGING_DIR)" \
> 
> I don't get why PKG_CONFIG_SYSROOT should be set here. The correct
> variable is PKG_CONFIG_SYSROOT_DIR and it is already set in
> TARGET_CONFIGURE_OPTS. I probably missed something specific to Qt, but
> I didn't understand the sentence: ?PKG_CONFIG_SYSROOT is only used to
> avoid a warning from Qt's configure system?.

Damn, I wanted to keep the comment short without being unclear, which
apparently failed. This extract from the file Qt/configure should make the use
of -force-pkg-config and PKG_CONFIG_SYSROOT clear. Qt should query
PKG_CONFIG_SYSROOT_DIR instead of PKG_CONFIG_SYSROOT. I've already sent a bug
report.

if [ "$QT_CROSS_COMPILE" = "yes" ]; then
    if [ -n "$QT_FORCE_PKGCONFIG" ]; then
        echo >&2 ""
        echo >&2 "You have asked to use pkg-config and are cross-compiling."
        echo >&2 "Please make sure you have a correctly set-up pkg-config"
        echo >&2 "environment!"
        echo >&2 ""
        if [ -z "$PKG_CONFIG_PATH" ]; then
            echo >&2 ""
            echo >&2 "Warning: PKG_CONFIG_PATH has not been set.  This could mean"
            echo >&2 "the host compiler's .pc files will be used. This is probably"
            echo >&2 "not what you want."
            echo >&2 ""
        elif [ -z "$PKG_CONFIG_SYSROOT" ]; then
            echo >&2 ""
            echo >&2 "Warning: PKG_CONFIG_SYSROOT has not been set. This means"
            echo >&2 "your toolchain's .pc files must contain the paths to the"
            echo >&2 "toolchain's libraries & headers. If configure tests are"
            echo >&2 "failing, please check these files."
            echo >&2 ""
        fi
    else
        PKG_CONFIG=""
    fi
fi

  reply	other threads:[~2008-10-28  8:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-28  1:51 [Buildroot] [PATCH] qtopia4: fix use of pkg-config Markus Heidelberg
2008-10-28  7:14 ` Thomas Petazzoni
2008-10-28  8:22   ` Markus Heidelberg [this message]
2008-10-28  8:50     ` Thomas Petazzoni
2008-10-28  9:38 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810280922.53728.markus.heidelberg@web.de \
    --to=markus.heidelberg@web.de \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.