From mboxrd@z Thu Jan 1 00:00:00 1970 From: Muli Ben-Yehuda Subject: Re: [PATCH 5/6] KVM/userspace: Device Assignment: Support for assigning PCI devices to guests Date: Tue, 28 Oct 2008 12:12:35 +0200 Message-ID: <20081028101235.GF7102@il.ibm.com> References: <1224861988-22781-1-git-send-email-amit.shah@redhat.com> <1224861988-22781-2-git-send-email-amit.shah@redhat.com> <1224861988-22781-3-git-send-email-amit.shah@redhat.com> <1224861988-22781-4-git-send-email-amit.shah@redhat.com> <1224861988-22781-5-git-send-email-amit.shah@redhat.com> <1224861988-22781-6-git-send-email-amit.shah@redhat.com> <715D42877B251141A38726ABF5CABF2C018681F1A0@pdsmsx503.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Su, Disheng" , Amit Shah , "avi@redhat.com" , "kvm@vger.kernel.org" , "anthony@codemonkey.ws" , "Kay, Allen M" , Ben-Ami Yassour1 To: "Han, Weidong" Return-path: Received: from mtagate8.de.ibm.com ([195.212.29.157]:61067 "EHLO mtagate8.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752498AbYJ1KOG (ORCPT ); Tue, 28 Oct 2008 06:14:06 -0400 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate8.de.ibm.com (8.13.8/8.13.8) with ESMTP id m9SADIju294488 for ; Tue, 28 Oct 2008 10:13:18 GMT Received: from d12av01.megacenter.de.ibm.com (d12av01.megacenter.de.ibm.com [9.149.165.212]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m9SADI2i1032432 for ; Tue, 28 Oct 2008 11:13:18 +0100 Received: from d12av01.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av01.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m9SADHvT006033 for ; Tue, 28 Oct 2008 11:13:17 +0100 Content-Disposition: inline In-Reply-To: <715D42877B251141A38726ABF5CABF2C018681F1A0@pdsmsx503.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Oct 27, 2008 at 02:32:48PM +0800, Han, Weidong wrote: > Yes, it's buggy. It should like: > > uint32_t old_ephys = region->e_physbase; > uint32_t old_esize = region->e_size; > > ... > > kvm_destroy_phys_mem(kvm_context, old_ephys, old_esize); Fixed in v8. Thanks! Cheers, Muli -- The First Workshop on I/O Virtualization (WIOV '08) Dec 2008, San Diego, CA, http://www.usenix.org/wiov08/ <-> SYSTOR 2009---The Israeli Experimental Systems Conference http://www.haifa.il.ibm.com/conferences/systor2009/