From mboxrd@z Thu Jan 1 00:00:00 1970 From: Muli Ben-Yehuda Subject: Re: [PATCH 1/6] KVM/userspace: Device Assignment: Add ioctl wrappers needed for assigning devices Date: Tue, 28 Oct 2008 12:13:04 +0200 Message-ID: <20081028101304.GH7102@il.ibm.com> References: <1224861988-22781-1-git-send-email-amit.shah@redhat.com> <1224861988-22781-2-git-send-email-amit.shah@redhat.com> <490470AF.8070207@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Amit Shah , kvm@vger.kernel.org, anthony@codemonkey.ws, weidong.han@intel.com, allen.m.kay@intel.com, Ben-Ami Yassour1 To: Avi Kivity Return-path: Received: from mtagate7.de.ibm.com ([195.212.29.156]:63986 "EHLO mtagate7.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752620AbYJ1KOb (ORCPT ); Tue, 28 Oct 2008 06:14:31 -0400 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.13.8/8.13.8) with ESMTP id m9SADlYk278742 for ; Tue, 28 Oct 2008 10:13:47 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m9SADlPZ3408042 for ; Tue, 28 Oct 2008 11:13:47 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m9SADkMt026995 for ; Tue, 28 Oct 2008 11:13:47 +0100 Content-Disposition: inline In-Reply-To: <490470AF.8070207@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Oct 26, 2008 at 03:29:19PM +0200, Avi Kivity wrote: > Amit Shah wrote: >> +#ifdef KVM_CAP_DEVICE_ASSIGNMENT >> +int kvm_assign_pci_device(kvm_context_t kvm, >> + struct kvm_assigned_pci_dev *assigned_dev) >> +{ >> + return ioctl(kvm->vm_fd, KVM_ASSIGN_PCI_DEVICE, assigned_dev); >> > > Convert -1s to -errno, to avoid problems with errno being > overwritten later. Done. Cheers, Muli -- The First Workshop on I/O Virtualization (WIOV '08) Dec 2008, San Diego, CA, http://www.usenix.org/wiov08/ <-> SYSTOR 2009---The Israeli Experimental Systems Conference http://www.haifa.il.ibm.com/conferences/systor2009/