From: Evgeniy Polyakov <zbr@ioremap.net>
To: hamid jafarian <hamid.jafarian@gmail.com>
Cc: Netfilter-devel <netfilter-devel@vger.kernel.org>,
Netdev <netdev@vger.kernel.org>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Patrick McHardy <kaber@trash.net>,
Jan Engelhardt <jengelh@medozas.de>,
Rusty Russell <rusty@rustcorp.com.au>,
Harald Welte <laforge@gnumonks.org>, Eric Leblond <eric@inl.fr>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Amin Azez <azez@ufomechanic.net>
Subject: Re: [PATCH 00/09]IPtablestng/Kernel - New Framework For IPtables
Date: Tue, 28 Oct 2008 13:43:46 +0300 [thread overview]
Message-ID: <20081028104346.GA31146@ioremap.net> (raw)
In-Reply-To: <464293e60810280302j26112754o72c1cf3ebd6a0b1f@mail.gmail.com>
Hi.
On Tue, Oct 28, 2008 at 01:32:06PM +0330, hamid jafarian (hamid.jafarian@gmail.com) wrote:
> excuse for this loosely patches...
> please more explain...
> do you mean my patches are too long? or ambiguous?
> i 've tried to code base on "Documentation/CodingStyle".. and patch
> base on "how to participate in the kernel community" documents.
>
> the core of this framework is located at pkt_tables.c&.h (#2 of
> kernel patches).
> iptables.c&.h are completely changed. also at the user space libiptc.c
> is rewritten from scratch thus their patches are really ambiguous to
> be understood..what is the best way to send this patches?
> what this phrase mean: "' remotely match existing code ""?
I mean just coding style: spaces, braces, parentheses, function names
like __something_small_AND_CAPITAL. checkpatch.pl may help, although imo
it should not be followed strickly. It will much simpler to review changes.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2008-10-28 10:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-27 4:28 [PATCH 00/09]IPtablestng/Kernel - New Framework For IPtables hamid jafarian
2008-10-28 0:00 ` Evgeniy Polyakov
2008-10-28 0:02 ` David Miller
2008-10-28 10:02 ` hamid jafarian
2008-10-28 10:43 ` Evgeniy Polyakov [this message]
2008-10-28 12:07 ` Patrick McHardy
2008-10-28 12:25 ` Evgeniy Polyakov
2008-10-28 12:30 ` Patrick McHardy
2008-10-28 12:43 ` Evgeniy Polyakov
2008-10-28 12:57 ` hamid jafarian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081028104346.GA31146@ioremap.net \
--to=zbr@ioremap.net \
--cc=azez@ufomechanic.net \
--cc=eric@inl.fr \
--cc=hamid.jafarian@gmail.com \
--cc=jengelh@medozas.de \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=laforge@gnumonks.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.