From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/7] sanitize xlog_in_core_t definition
Date: Wed, 29 Oct 2008 08:51:11 +1100 [thread overview]
Message-ID: <20081028215111.GZ4985@disturbed> (raw)
In-Reply-To: <20081028091614.GC1662@infradead.org>
On Tue, Oct 28, 2008 at 05:16:14AM -0400, Christoph Hellwig wrote:
> On Tue, Oct 28, 2008 at 04:17:34PM +1100, Dave Chinner wrote:
> > > -typedef union xlog_in_core2 {
> > > - xlog_rec_header_t hic_header;
> > > - xlog_rec_ext_header_t hic_xheader;
> > > - char hic_sector[XLOG_HEADER_SIZE];
> > > -} xlog_in_core_2_t;
> > > -
> > > -typedef struct xlog_in_core {
> > > - xlog_iclog_fields_t hic_fields;
> > > - xlog_in_core_2_t *hic_data;
> > > + xlog_in_core_2_t *ic_data;
> > > +#define ic_header ic_data->hic_header
> > > } xlog_in_core_t;
> >
> > The ic_data pointer should not be on the same cacheline as the
> > reference count seeing as it is read-only field.
>
> Makes sense, but I'll leave that for a separate patch to keep things
> bisectable.
ok.
Reviewed-by: Dave Chinner <david@fromorbit.com>
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2008-10-28 21:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-27 13:39 [PATCH 3/7] sanitize xlog_in_core_t definition Christoph Hellwig
2008-10-28 5:17 ` Dave Chinner
2008-10-28 9:16 ` Christoph Hellwig
2008-10-28 21:51 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081028215111.GZ4985@disturbed \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.