From: Ingo Molnar <mingo@elte.hu>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: two trivial sparse annotations
Date: Wed, 29 Oct 2008 08:03:57 +0100 [thread overview]
Message-ID: <20081029070357.GE7936@elte.hu> (raw)
In-Reply-To: <1225260322.20276.2.camel@brick>
* Harvey Harrison <harvey.harrison@gmail.com> wrote:
> arch/x86/kernel/vsmp_64.c:87:14: warning: incorrect type in argument 1 (different address spaces)
> arch/x86/kernel/vsmp_64.c:87:14: expected void const volatile [noderef] <asn:2>*addr
> arch/x86/kernel/vsmp_64.c:87:14: got void *[assigned] address
> arch/x86/kernel/vsmp_64.c:88:22: warning: incorrect type in argument 1 (different address spaces)
> arch/x86/kernel/vsmp_64.c:88:22: expected void const volatile [noderef] <asn:2>*addr
> arch/x86/kernel/vsmp_64.c:88:22: got void *
> arch/x86/kernel/vsmp_64.c:100:23: warning: incorrect type in argument 2 (different address spaces)
> arch/x86/kernel/vsmp_64.c:100:23: expected void volatile [noderef] <asn:2>*addr
> arch/x86/kernel/vsmp_64.c:100:23: got void *
> arch/x86/kernel/vsmp_64.c:101:23: warning: incorrect type in argument 1 (different address spaces)
> arch/x86/kernel/vsmp_64.c:101:23: expected void const volatile [noderef] <asn:2>*addr
> arch/x86/kernel/vsmp_64.c:101:23: got void *
> arch/x86/mm/gup.c:235:6: warning: incorrect type in argument 1 (different base types)
> arch/x86/mm/gup.c:235:6: expected void const volatile [noderef] <asn:1>*<noident>
> arch/x86/mm/gup.c:235:6: got unsigned long [unsigned] [assigned] start
>
> Impact: fewer sparse warnings, no functional changes
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> arch/x86/kernel/vsmp_64.c | 2 +-
> arch/x86/mm/gup.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
applied to tip/x86/urgent, thanks Harvey!
i see you started using the impact-line, nice :) I moved it to the top
of the commit, that's where we generally put it. (it acts as a
secondary subject line in essence, so sits right next to the first
line of the commit)
Ingo
prev parent reply other threads:[~2008-10-29 7:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 6:05 [PATCH] x86: two trivial sparse annotations Harvey Harrison
2008-10-29 7:03 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081029070357.GE7936@elte.hu \
--to=mingo@elte.hu \
--cc=harvey.harrison@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.