From: Andrew Morton <akpm@linux-foundation.org>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: jeff@garzik.org, netdev@vger.kernel.org
Subject: Re: [patch 6/7] drivers/net/sfc/falcon.c: fix min() warnings
Date: Wed, 29 Oct 2008 14:35:40 -0700 [thread overview]
Message-ID: <20081029143540.c4e24fb5.akpm@linux-foundation.org> (raw)
In-Reply-To: <1225315744.3068.54.camel@achroite>
On Wed, 29 Oct 2008 21:29:04 +0000
Ben Hutchings <bhutchings@solarflare.com> wrote:
> On Wed, 2008-10-29 at 14:22 -0700, akpm@linux-foundation.org wrote:
> > From: Andrew Morton <akpm@linux-foundation.org>
> >
> > drivers/net/sfc/falcon.c: In function 'falcon_spi_write_limit':
> > drivers/net/sfc/falcon.c:1679: warning: comparison of distinct pointer types lacks a cast
> > drivers/net/sfc/falcon.c: In function 'falcon_spi_read':
> > drivers/net/sfc/falcon.c:1720: warning: comparison of distinct pointer types lacks a cast
>
> These were already fixed by 31b760202a0911384fa07796df9d1905e9e89a7f.
That patch worsened things.
> > Driver seems rather confused about types. Try to help it.
> [...]
>
> Maybe, but in order to fix that you'll need to revert
> 31b760202a0911384fa07796df9d1905e9e89a7f along with making these
> changes.
I have plenty of things to be going on with.
next prev parent reply other threads:[~2008-10-29 21:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 21:22 [patch 6/7] drivers/net/sfc/falcon.c: fix min() warnings akpm
2008-10-29 21:29 ` Ben Hutchings
2008-10-29 21:35 ` Andrew Morton [this message]
2008-11-06 5:39 ` Jeff Garzik
2008-11-06 12:33 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081029143540.c4e24fb5.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bhutchings@solarflare.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.