From: Andrew Morton <akpm@linux-foundation.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-scsi@vger.kernel.org, tbm@cyrius.com
Subject: Re: [patch 14/17] scsi: fix bad use of udelay in atp870u.c
Date: Wed, 29 Oct 2008 15:02:43 -0700 [thread overview]
Message-ID: <20081029150243.27e9a4a2.akpm@linux-foundation.org> (raw)
In-Reply-To: <1225316535.3257.16.camel@localhost.localdomain>
On Wed, 29 Oct 2008 16:42:15 -0500
James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> On Wed, 2008-10-29 at 14:24 -0700, akpm@linux-foundation.org wrote:
> > - udelay(0x800);
> > + mdelay(2);
> > + udelay(48);
>
> OK, this fix is obviously wrong ... the code holds off interrupts for
> two ticks that's clearly completely bogus. In this case silencing the
> warning is hiding the bogosity ... now if only someone could actually
> fix it ...
>
That'll take some heavy lifting. There's an mdelay(128) a few lines up!
I'd suggest that you merge this to fix the ARM build then hurriedly
find something else to look at :(
prev parent reply other threads:[~2008-10-29 22:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 21:24 [patch 14/17] scsi: fix bad use of udelay in atp870u.c akpm
2008-10-29 21:42 ` James Bottomley
2008-10-29 22:02 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081029150243.27e9a4a2.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.