From: Jens Axboe <jens.axboe@oracle.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: malahal@us.ibm.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] block: optimizations in blk_rq_timed_out_timer()
Date: Thu, 30 Oct 2008 09:55:20 +0100 [thread overview]
Message-ID: <20081030085520.GP31673@kernel.dk> (raw)
In-Reply-To: <20081030172918Z.fujita.tomonori@lab.ntt.co.jp>
On Thu, Oct 30 2008, FUJITA Tomonori wrote:
> On Thu, 30 Oct 2008 08:49:07 +0100
> Jens Axboe <jens.axboe@oracle.com> wrote:
>
> > > > What
> > > > likely can happen is that we may call mod_timer with jiffies that is
> > > > older than current which would call the timer immediately...
> > >
> > > Yeah, I think that the timer is called immediately here. It's
> > > unnecessary.
> >
> > Hmm, just checked the code, and indeed it does. Have the timers always
> > behaved like that?
>
> I guess so because it's unrealistic that the caller of mod_time makes
> sure that expires is future time, in particular if the caller wants
> short timeout?
It's all a little confusing, I think. When do you stop considering it a
little in the past and long into the future?
--
Jens Axboe
next prev parent reply other threads:[~2008-10-30 8:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 18:22 [PATCH] block: optimizations in blk_rq_timed_out_timer() malahal
2008-10-29 4:07 ` FUJITA Tomonori
2008-10-29 6:06 ` malahal
2008-10-29 13:26 ` Jens Axboe
2008-10-29 18:21 ` malahal
2008-10-30 2:33 ` FUJITA Tomonori
2008-10-30 7:49 ` Jens Axboe
2008-10-30 8:29 ` FUJITA Tomonori
2008-10-30 8:55 ` Jens Axboe [this message]
2008-10-30 10:29 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081030085520.GP31673@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-scsi@vger.kernel.org \
--cc=malahal@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.