From: Dave Chinner <david@fromorbit.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: xfs-masters@oss.sgi.com, linux-next@vger.kernel.org,
Lachlan McIlroy <lachlan@sgi.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: linux-next: xfs tree build failure
Date: Thu, 30 Oct 2008 20:08:32 +1100 [thread overview]
Message-ID: <20081030090832.GQ17077@disturbed> (raw)
In-Reply-To: <20081030132324.0d619fdd.sfr@canb.auug.org.au>
On Thu, Oct 30, 2008 at 01:23:24PM +1100, Stephen Rothwell wrote:
> Hi David,
>
> Today's linux-next build (powerpc ppc64_defconfig) failed like this:
>
> ERROR: "inode_wait" [fs/xfs/xfs.ko] undefined!
>
> Caused by commit 676a7711ee281c3bf41db18e29e296584de82793 ("[XFS] Fix
> race when looking up reclaimable inodes") which introduced a use of
> wait_on_inode() which is an inline that calls inode_wait().
Putting a non-exported symbol in an inline function in a header file
that is full of exported functions. That's pretty anti-social. ;)
> I applied the following patch (probably wrong :-)).
I think it's probably the only solution - we need to wait until
the I_LOCK bit is cleared from the inode and AFAICT wait_on_inode()
is the only way to do it.
Christoph?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-10-30 9:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 2:23 linux-next: xfs tree build failure Stephen Rothwell
2008-10-30 9:08 ` Dave Chinner [this message]
2008-11-05 2:20 ` Stephen Rothwell
2008-11-05 20:47 ` Dave Chinner
2008-11-06 15:27 ` Christoph Hellwig
2008-11-07 5:06 ` Stephen Rothwell
2008-11-11 2:05 ` Lachlan McIlroy
2008-11-11 2:11 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2008-12-03 23:16 Stephen Rothwell
2008-12-04 5:20 ` Eric Sandeen
2009-03-10 2:45 Stephen Rothwell
2009-03-11 22:52 ` Dave Chinner
2009-03-12 1:04 ` Stephen Rothwell
2009-03-15 12:18 ` Dave Chinner
2009-07-03 0:05 Stephen Rothwell
2009-09-02 1:25 Stephen Rothwell
2009-09-02 1:28 ` Christoph Hellwig
2009-09-02 1:54 ` Felix Blyakher
2009-09-02 2:00 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081030090832.GQ17077@disturbed \
--to=david@fromorbit.com \
--cc=lachlan@sgi.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=xfs-masters@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.