From: Theodore Tso <tytso@mit.edu>
To: "Jörn Engel" <joern@logfs.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Arjan van de Ven <arjan@infradead.org>,
Mike Snitzer <snitzer@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Daniel Walker <dwalker@mvista.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 1/2 v3][RFC] trace: profile likely and unlikely annotations
Date: Thu, 30 Oct 2008 10:55:43 -0400 [thread overview]
Message-ID: <20081030145543.GC14744@mit.edu> (raw)
In-Reply-To: <20081030143238.GB7157@logfs.org>
On Thu, Oct 30, 2008 at 03:32:39PM +0100, Jörn Engel wrote:
> On Wed, 29 October 2008 18:39:55 -0400, Steven Rostedt wrote:
> >
> > 69768 61064 87 __switch_to process_64.c 624
> > 15557 115251 100 __switch_to process_64.c 594
> > 15555 115227 100 __switch_to process_64.c 590
>
> I may be out of school for a while, but that math sure looks odd.
>
> > + if (p->correct) {
> > + percent = p->incorrect * 100;
> > + percent /= p->correct;
> percent /= p->correct + p->incorect;
And once you do the above fix, I don't think what is below is
necessary any more. :-)
> > + /* No need to see huge numbers */
> > + if (percent > 100)
> > + percent = 100;
I would also calculate the percent correct rather than the percent
incorrect, on the general theory that 100% good, 0% bad is easier for
my little brain to understand, but that's just a minor thing...
- Ted
next prev parent reply other threads:[~2008-10-30 14:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-27 22:29 why unlikely(rsv) in ext3_clear_inode()? Mike Snitzer
2008-10-27 22:53 ` Steven Rostedt
2008-10-27 23:32 ` Steven Rostedt
2008-10-27 23:48 ` Andrew Morton
2008-10-28 0:13 ` Theodore Tso
2008-10-28 0:21 ` Steven Rostedt
2008-10-28 4:12 ` [PATCH][RFC] trace: profile likely and unlikely annotations Steven Rostedt
2008-10-28 4:23 ` Arjan van de Ven
2008-10-28 4:39 ` Andrew Morton
2008-10-28 14:37 ` Theodore Tso
2008-10-28 14:48 ` Arjan van de Ven
2008-10-28 14:51 ` Steven Rostedt
2008-10-29 16:35 ` [PATCH 1/2 v2][RFC] " Steven Rostedt
2008-10-29 16:38 ` [PATCH 2/2 v2][RFC] ftrace: unlikely annotation tracer Steven Rostedt
2008-10-29 16:40 ` [PATCH 1/2 v2][RFC] trace: profile likely and unlikely annotations Arjan van de Ven
2008-10-29 22:39 ` [PATCH 1/2 v3][RFC] " Steven Rostedt
2008-10-29 22:40 ` [PATCH 2/2 v3][RFC] ftrace: unlikely annotation tracer Steven Rostedt
2008-10-30 14:32 ` [PATCH 1/2 v3][RFC] trace: profile likely and unlikely annotations Jörn Engel
2008-10-30 14:55 ` Theodore Tso [this message]
2008-10-30 15:10 ` Steven Rostedt
2008-10-28 14:49 ` [PATCH][RFC] " Steven Rostedt
2008-10-28 18:29 ` Theodore Tso
2008-10-28 18:41 ` Steven Rostedt
2008-10-28 0:14 ` why unlikely(rsv) in ext3_clear_inode()? Mike Snitzer
2008-10-27 23:52 ` Mingming Cao
2008-10-28 0:09 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081030145543.GC14744@mit.edu \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=dwalker@mvista.com \
--cc=fweisbec@gmail.com \
--cc=joern@logfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=snitzer@gmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.