From: Oliver Neukum <oliver@neukum.org>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [patch]liberal acceptance of 0x28 asc in sd.c
Date: Thu, 30 Oct 2008 15:23:13 +0100 [thread overview]
Message-ID: <200810301523.13569.oliver@neukum.org> (raw)
In-Reply-To: <1225375273.3250.9.camel@localhost.localdomain>
Am Donnerstag, 30. Oktober 2008 15:01:13 schrieb James Bottomley:
> On Thu, 2008-10-30 at 13:09 +0100, Oliver Neukum wrote:
> > >From reading the SCSI spec it seems that having the valid bit 0 (0x70
> > checked in scsi_sense_valid) should does not invalidate the ASC or ASQ.
> > [See page 37 of spc4r02.pdf].
>
> That's a correct reading of the spec as regards the valid bit for non
> descriptor sense data, but not applicable to this situation. sense_valid
> is generated from (byte[0] & 0x70 == 0x70) (see scsi_sense_valid() in
> include/scsi/scsi_eh.h) not from the valid bit. This test is *required*
> by the standard otherwise what we have isn't sense data.
>
> > It should only invalidate the INFORMATION
> > field. Therefore remove the sense_valid check from the USB quirk.
> >
> > This is needed for a strange USB storage device.
>
> Could you elaborate a bit more? What's its problem (and what is it
> replying as byte 0 to a REQUEST_SENSE)?
I got a report about a storage device that reports 0x28 and scsi_sense_valid()
returns false.
> > Signed-off-by: Brandon Philips <bphilips@suse.de>
> > Signed-off-by: Oliver Neukum <oneukum@suse.de>
>
> These signoffs don't make sense for what you sent ... this implies that
> its Brandon's patch which you altered, in which case it needs a From: at
> the beginning to make him the author.
I wrote it.
Regards
Oliver
prev parent reply other threads:[~2008-10-30 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 12:09 [patch]liberal acceptance of 0x28 asc in sd.c Oliver Neukum
2008-10-30 14:01 ` James Bottomley
2008-10-30 14:23 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810301523.13569.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.