All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <florian@openwrt.org>
To: Phil Sutter <n0-1@freewrt.org>
Cc: Linux-Mips List <linux-mips@linux-mips.org>
Subject: Re: [PATCH] provide functions for gpio configuration
Date: Thu, 30 Oct 2008 18:13:05 +0100	[thread overview]
Message-ID: <200810301813.05710.florian@openwrt.org> (raw)
In-Reply-To: <20081029211046.GC17108@nuty>

Hi Phil,

Le Wednesday 29 October 2008 22:10:46 Phil Sutter, vous avez écrit :
> Yes it does, but that's not part of gpiolib itself. Accessing them needs
> a combination of gpio_to_chip() and container_of() to be used, which I
> doubt makes sense on a device with a single, platform gpio chip.

Yes, that makes it unexportable the way it is done yet. What I suggest is not 
overriding the struct rb532_gpio_chip with thoses callbacks, but do like you 
suggested initially.

> I'm not sure if this is absolutely true. The original CompactFlash
> driver e.g. clears interrupt level in cf_irq_handler() and sets it in
> prepare_cf_irq(). The latter function is called more than once.

This should be moved the IRQ handler, where a specific check for the IRQ being 
a GPIO one should set the interrupt status and level accordingly.

Thanks.
-- 
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------

  reply	other threads:[~2008-10-30 17:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-29 20:00 [PATCH] provide functions for gpio configuration Phil Sutter
2008-10-29 20:07 ` Florian Fainelli
2008-10-29 21:10   ` Phil Sutter
2008-10-30 17:13     ` Florian Fainelli [this message]
2008-10-30 17:47       ` Phil Sutter
2008-10-30 18:16         ` Florian Fainelli
2008-10-30 20:20           ` Phil Sutter
2008-10-30 20:26             ` Florian Fainelli
2008-10-31  0:25             ` [PATCH] add prototypes for the exported symbols Phil Sutter
2008-10-31 14:58               ` [PATCH] provide functions for gpio configuration Phil Sutter
2008-11-02 21:56                 ` Sergei Shtylyov
2008-11-03 14:29                   ` Phil Sutter
2008-11-03 14:30                     ` [PATCH] MIPS: rb532: fix bit swapping in rb532_set_bit() Phil Sutter
2008-11-03 14:48                       ` Atsushi Nemoto
2008-11-03 15:05                         ` Phil Sutter
2008-11-11 23:09                           ` Phil Sutter
2009-01-29 16:27                             ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810301813.05710.florian@openwrt.org \
    --to=florian@openwrt.org \
    --cc=linux-mips@linux-mips.org \
    --cc=n0-1@freewrt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.