All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jan Beulich <jbeulich@novell.com>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, hpa@zytor.com
Subject: Re: [PATCH] x86: simplify X86_MPPARSE config option
Date: Thu, 30 Oct 2008 19:14:45 +0100	[thread overview]
Message-ID: <20081030181445.GF4675@elte.hu> (raw)
In-Reply-To: <4909A212.76E4.0078.0@novell.com>


* Jan Beulich <jbeulich@novell.com> wrote:

> >>> Ingo Molnar <mingo@elte.hu> 30.10.08 11:51 >>>
> >
> >* Jan Beulich <jbeulich@novell.com> wrote:
> >
> >> Signed-off-by: Jan Beulich <jbeulich@novell.com>
> >> 
> >> ---
> >>  arch/x86/Kconfig |   12 ++----------
> >>  1 file changed, 2 insertions(+), 10 deletions(-)
> >> 
> >> --- linux-2.6.28-rc2/arch/x86/Kconfig	2008-10-30 11:03:18.000000000 +0100
> >> +++ 2.6.28-rc2-x86-kconfig-cleanup/arch/x86/Kconfig	2008-10-21 13:57:07.000000000 +0200
> >> @@ -235,21 +235,13 @@ config X86_FIND_SMP_CONFIG
> >>  	def_bool y
> >>  	depends on X86_MPPARSE || X86_VOYAGER
> >>  
> >> -if ACPI
> >>  config X86_MPPARSE
> >> -	def_bool y
> >> -	bool "Enable MPS table"
> >> +	bool "Enable MPS table" if ACPI
> >> +	default y
> >>  	depends on X86_LOCAL_APIC
> >>  	help
> >>  	  For old smp systems that do not have proper acpi support. Newer systems
> >>  	  (esp with 64bit cpus) with acpi support, MADT and DSDT will override it
> >> -endif
> >> -
> >> -if !ACPI
> >> -config X86_MPPARSE
> >> -	def_bool y
> >> -	depends on X86_LOCAL_APIC
> >> -endif
> >
> >hm, that's not an equivalent change. But i guess we can do this, it 
> >sure looks like a cleaner construct.
> 
> Why is it not equivalent (apart from the help portion, which doesn't 
> matter when the prompt isn't visible)?

you are right, it's equivalent - the "if ACPI" makes interactivity 
(the prompt) conditional, not the option.

applied to tip/x86/cleanups, thanks!

	Ingo

      parent reply	other threads:[~2008-10-30 18:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-30 10:38 [PATCH] x86: simplify X86_MPPARSE config option Jan Beulich
2008-10-30 10:51 ` Ingo Molnar
2008-10-30 11:01   ` Jan Beulich
2008-10-30 12:28     ` Adrian Bunk
2008-10-30 18:14     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081030181445.GF4675@elte.hu \
    --to=mingo@elte.hu \
    --cc=hpa@zytor.com \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.