From: Jens Axboe <jens.axboe@oracle.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: device-mapper development <dm-devel@redhat.com>,
Kiyoshi Ueda <k-ueda@ct.jp.nec.com>,
linux-kernel@vger.kernel.org, Alasdair G Kergon <agk@redhat.com>
Subject: Re: [dm-devel] [PATCH] Add gfp_mask to bio_integrity_clone()
Date: Fri, 31 Oct 2008 15:17:02 +0100 [thread overview]
Message-ID: <20081031141701.GI31673@kernel.dk> (raw)
In-Reply-To: <yq1hc6s3l4g.fsf@sermon.lab.mkp.net>
On Fri, Oct 31 2008, Martin K. Petersen wrote:
> >>>>> "Jun'ichi" == Jun'ichi Nomura <j-nomura@ce.jp.nec.com> writes:
>
> Jun'ichi> What do you think about adding gfp_mask parameter to
> Jun'ichi> bio_integrity_clone() like the attached patch?
>
> Jun'ichi> It also seems natural to inherit gfp_mask from bio_clone
> Jun'ichi> when bio_integrity_clone is called from it. Since
> Jun'ichi> bio_clone() is the only caller of bio_integrity_clone() in
> Jun'ichi> 2.6.28-rc2 and all in-tree callers of bio_clone() are using
> Jun'ichi> GFP_NOIO, the patch does nothing other than changing the
> Jun'ichi> interface.
>
> Looks good to me. I'll update the non-multipath DM bits accordingly.
>
> Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
Shall I just include this in the 2.6.29 branch?
--
Jens Axboe
next prev parent reply other threads:[~2008-10-31 14:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 5:15 [PATCH] Add gfp_mask to bio_integrity_clone() Jun'ichi Nomura
2008-10-30 5:15 ` Jun'ichi Nomura
2008-10-31 14:16 ` Martin K. Petersen
2008-10-31 14:16 ` [dm-devel] " Martin K. Petersen
2008-10-31 14:17 ` Jens Axboe [this message]
2008-10-31 16:25 ` Martin K. Petersen
2008-10-31 16:25 ` [dm-devel] " Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081031141701.GI31673@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=k-ueda@ct.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.