From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 4/5] XFS: fix spurious uninitialised variable warning in xfs_growfs_rt
Date: Fri, 31 Oct 2008 16:20:27 -0400 [thread overview]
Message-ID: <20081031202027.GC20309@infradead.org> (raw)
In-Reply-To: <1225415729-26514-5-git-send-email-david@fromorbit.com>
On Fri, Oct 31, 2008 at 12:15:28PM +1100, Dave Chinner wrote:
> gcc is warning about an uninitialised variable in xfs_growfs_rt().
> This is a false positive. Fix it by changing the scope of the
> transaction pointer to wholly within the internal loop inside
> the function.
>
> While there, preemptively change xfs_growfs_rt_alloc() in the
> same way as it has exactly the same structure as xfs_growfs_rt()
> but gcc is not warning about it. Yet.
Looks good.
next prev parent reply other threads:[~2008-10-31 20:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 1:15 [PATCH 0/5] Miscellaneous bug fixes Dave Chinner
2008-10-31 1:15 ` [PATCH 1/5] XFS: fix error inversion problems with data flushing Dave Chinner
2008-10-31 20:18 ` Christoph Hellwig
2008-11-02 22:51 ` Dave Chinner
2008-11-06 15:39 ` Christoph Hellwig
2008-10-31 1:15 ` [PATCH 2/5] XFS: Fix double free of log tickets Dave Chinner
2008-11-12 9:20 ` Christoph Hellwig
2008-10-31 1:15 ` [PATCH 3/5] XFS: fix uninitialised variable bug in dquot release Dave Chinner
2008-10-31 20:19 ` Christoph Hellwig
2008-10-31 1:15 ` [PATCH 4/5] XFS: fix spurious uninitialised variable warning in xfs_growfs_rt Dave Chinner
2008-10-31 20:20 ` Christoph Hellwig [this message]
2008-10-31 1:15 ` [PATCH 5/5] XFS: Avoid using inodes that haven't been completely initialised Dave Chinner
2008-10-31 20:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081031202027.GC20309@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.