From: Christoph Hellwig <hch@infradead.org>
To: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: do_sync() and XFSQA test 182 failures....
Date: Fri, 31 Oct 2008 18:19:46 -0400 [thread overview]
Message-ID: <20081031221946.GA29761@infradead.org> (raw)
In-Reply-To: <20081031220349.GC19509@disturbed>
On Sat, Nov 01, 2008 at 09:03:49AM +1100, Dave Chinner wrote:
> > > if (!(sb->s_flags & MS_RDONLY))
> > > + xfs_sync_fsdata(XFS_M(sb), SYNC_WAIT);
> >
> > Not commenting on the rest yet, but I'm sure you noticed that before
> > your patch we ever called xfs_sync_fsdata with SYNC_WAIT at all. I
> > think with the current codebase there is nothing to guarantee we ever
> > write the superblock out to disk as xfs_wait_buftarg specificly
> > excludes the superblock (XBF_FS_MANAGED)
>
> Almost. unmount calls xfs_unmountfs_writesb() which does a
> synchronous write of the superblock. But in the current code sync(1)
> certainly never, ever triggers a superblock write we wait for...
True, missed it due to the opencoding. With my patch to kill the
shared readonly bits we should be able to make it use xfs_sync_fsdata
for consistency.
next prev parent reply other threads:[~2008-10-31 22:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 8:50 do_sync() and XFSQA test 182 failures Dave Chinner
2008-10-30 22:46 ` Christoph Hellwig
2008-10-31 0:12 ` Dave Chinner
2008-10-31 0:48 ` Dave Chinner
2008-10-31 20:37 ` Christoph Hellwig
2008-10-31 22:03 ` Dave Chinner
2008-10-31 22:19 ` Christoph Hellwig [this message]
2008-10-31 20:31 ` Christoph Hellwig
2008-10-31 21:54 ` Dave Chinner
2008-10-31 22:22 ` Christoph Hellwig
2008-10-31 4:02 ` Lachlan McIlroy
2008-10-31 13:06 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081031221946.GA29761@infradead.org \
--to=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.