All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] Re: [PATCH][RFC] Run time TCGv size check for debugging
Date: Sat, 1 Nov 2008 13:59:51 +0100	[thread overview]
Message-ID: <200811011259.52947.paul@codesourcery.com> (raw)
In-Reply-To: <f43fc5580811010500n48bcef6ay9ddfdaa89884d3f0@mail.gmail.com>

> This version introduces TCGv_i32 and TCGv_i64. TCGv_ptr and TCGv (TL
> sized) are based on them.

This is looking good to me.

> For Sparc, the patch is very invasive (I just commented out the
> helpers to avoid that part)  but I think i386 would need much smaller
> changes.
>
> With the patch, I found some bugs in Sparc translation. I'm not sure
> what to do with helpers, there should be a way to declare the size of
> the arguments somehow and then the calling should be easier than:
> tcg_gen_helper_1_4_i64_tl_i32_i32_i32(helper_ld_asi, dst, addr, r_asi,
> r_size, r_sign);

I think we can build some infrastructure to make helpers easier to handle.  
It should be relatively mechanical changes to the existing helper[s].h.  ARM 
and m68k already do this, though need a bit more work to get static 
typechecking.  All the information it there's it's just not quite in the 
right form.  I'll see if I can dig out the CPP magic required for this.

Paul

  reply	other threads:[~2008-11-01 13:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-29 19:31 [Qemu-devel] [PATCH][RFC] Run time TCGv size check for debugging Blue Swirl
2008-10-29 19:53 ` Paul Brook
2008-10-29 20:06   ` Blue Swirl
2008-10-29 20:14     ` Paul Brook
2008-10-29 20:25       ` Blue Swirl
2008-10-29 21:37 ` [Qemu-devel] " Fabrice Bellard
2008-10-30  0:07   ` Paul Brook
2008-10-30  9:38     ` Fabrice Bellard
2008-11-01 12:00       ` Blue Swirl
2008-11-01 12:59         ` Paul Brook [this message]
2008-11-01 16:56           ` Paul Brook
2008-11-01 17:03             ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811011259.52947.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.