From: David Miller <davem@davemloft.net>
To: mcarlson@broadcom.com
Cc: netdev@vger.kernel.org, mchan@broadcom.com, andy@greyhouse.net
Subject: Re: [PATCH 02/15] tg3: Use pci_ioremap_bar()
Date: Mon, 03 Nov 2008 16:50:46 -0800 (PST) [thread overview]
Message-ID: <20081103.165046.71461900.davem@davemloft.net> (raw)
In-Reply-To: <1225751618.6169@xw6200>
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Mon, 3 Nov 2008 02:10:35 -0800
> This patch replaces the existing APE register mapping code with a call
> to pci_ioremap_bar(). The code that maps the main device register space
> did not undergo a similar change because the information derived from
> the pci_resource_start() and pci_resource_len() is still used to
> populate the (optional) mem_start and mem_end netdevice members.
> Replace hardcoded constants where appropriate.
>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied, but I think you can simply just remove those
dev->mem_start and dev->mem_end settings, they are
completely useles and if that is the only thing blocking
universal use of pci_ioremap_bar() it is yet another
reason to remove them.
prev parent reply other threads:[~2008-11-04 0:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-03 10:10 [PATCH 02/15] tg3: Use pci_ioremap_bar() Matt Carlson
2008-11-04 0:50 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081103.165046.71461900.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.