From: David Miller <davem@davemloft.net>
To: afleming@gmail.com
Cc: mcarlson@broadcom.com, netdev@vger.kernel.org,
mchan@broadcom.com, andy@greyhouse.net
Subject: Re: [PATCH 09/15] tg3: Allow WOL for phylib controlled Broadcom phys
Date: Mon, 03 Nov 2008 16:54:37 -0800 (PST) [thread overview]
Message-ID: <20081103.165437.02556544.davem@davemloft.net> (raw)
In-Reply-To: <2acbd3e40811031509q3d3005e5g9fedd842a1d08a52@mail.gmail.com>
From: "Andy Fleming" <afleming@gmail.com>
Date: Mon, 3 Nov 2008 17:09:34 -0600
> On Mon, Nov 3, 2008 at 4:13 AM, Matt Carlson <mcarlson@broadcom.com> wrote:
> > This patch allows WOL to be enabled for Broadcom phys under phylib
> > control. The only exception is the AC131, which has a completely
> > different register set.
> >
> > Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
> > Signed-off-by: Michael Chan <mchan@broadcom.com>
>
> Code to enable WOL sounds like the sort of thing we'd want in the PHY
> driver itself, rather than a manual setup done from the NIC driver.
> Clearly, we need support for WOL on both in order for it to work,
> though, so I can see two solutions off the top of my head:
...
I've applied Matt's patch, but I hope that you two will continue
the dialogue about this issue.
next prev parent reply other threads:[~2008-11-04 0:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-03 10:13 [PATCH 09/15] tg3: Allow WOL for phylib controlled Broadcom phys Matt Carlson
2008-11-03 23:09 ` Andy Fleming
2008-11-04 0:54 ` David Miller [this message]
2008-11-04 2:46 ` Matt Carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081103.165437.02556544.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=afleming@gmail.com \
--cc=andy@greyhouse.net \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.