From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kwmv3-0000bf-47 for qemu-devel@nongnu.org; Sun, 02 Nov 2008 19:03:45 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kwmv2-0000bT-83 for qemu-devel@nongnu.org; Sun, 02 Nov 2008 19:03:44 -0500 Received: from [199.232.76.173] (port=48523 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kwmv1-0000bO-WE for qemu-devel@nongnu.org; Sun, 02 Nov 2008 19:03:44 -0500 Received: from imta-38.everyone.net ([216.200.145.38]:55182 helo=omta0101.mta.everyone.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kwmv1-0002iQ-Fb for qemu-devel@nongnu.org; Sun, 02 Nov 2008 19:03:43 -0500 Date: Sun, 2 Nov 2008 19:03:40 -0500 From: Kevin O'Connor Message-ID: <20081103000340.GA12026@morn.localdomain> References: <20081027101249.21464.57377.stgit@gleb-debian.qumranet.com.qumranet.com> <20081027101259.21464.36016.stgit@gleb-debian.qumranet.com.qumranet.com> <20081102163159.GA10660@morn.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: [Qemu-devel] Re: [Bochs-developers] [PATCH 2/6] Add S3 state to DSDT. Handleresumeevent in the BIOS. Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sebastian Herbszt Cc: bochs-developers@lists.sourceforge.net, qemu-devel@nongnu.org, Gleb Natapov On Mon, Nov 03, 2008 at 12:28:08AM +0100, Sebastian Herbszt wrote: > Kevin O'Connor wrote: >> On Thu, Oct 30, 2008 at 11:41:28PM +0100, Sebastian Herbszt wrote: >>> It should not return if BX_USE_EBDA_TABLES is defined. >> BX_USE_EBDA_TABLES is broken. I think we'd be better off removing it >> instead of adding more to it. > > Can you define "broken"? Well, I think you answered your own question. However, I'm aware of the following problems: 1 - it uses memory that clashes with the ipl table 2 - it places the smbios in the ebda, but the smbios spec states it must be located in the 0xf0000 segment. 3 - from a style point of view, it's rather ugly to spread ifdefs throughout the code - if having bios tables in ebda is desired, then wrapper functions should be introduced 4 - it's an unnecessary complication - writing to 0xf0000 works. Why maintain code that is unneeded and doesn't work? -Kevin