From: Evgeniy Polyakov <zbr@ioremap.net>
To: Phillip Lougher <phillip@lougher.demon.co.uk>
Cc: akpm@linux-foundation.org, linux-embedded@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
tim.bird@am.sony.com
Subject: Re: [PATCH V2 00/16] Squashfs: compressed read-only filesystem
Date: Mon, 3 Nov 2008 17:14:50 +0300 [thread overview]
Message-ID: <20081103141450.GC27263@ioremap.net> (raw)
In-Reply-To: <E1Kv0C3-0006GU-ES@dylan>
Hi.
On Wed, Oct 29, 2008 at 01:49:55AM +0000, Phillip Lougher (phillip@lougher.demon.co.uk) wrote:
> Summary of changes in patch respin:
>
> 1. Functions changed to return 0 on success and -ESOMETHING on error
> 2. Header files moved from include/linux to fs/squashfs
> 3. Variables changed to use sb and inode
> 4. Number of squashfs_read_metadata() parameters reduced
> 5. Xattr placeholder code tweaked
> 6. TRACE and ERROR macros fixed to use pr_debug and pr_warning
> 7. Some obsolete macros in squashfs_fs.h removed
> 8. A number of gotos to return statements replaced with direct returns
> 9. Sparse with endian checking (make C=2 CHECKFLAGS="-D__CHECK_ENDIAN__")
> errors fixed
> 10. get_dir_index_using_name() misaligned access fixed
> 11. Fix a couple of printk warnings on PPC64
> 12. Shorten a number of variable names
Looks very good.
As a generic comment of the style: imho u64 is more appropriate than
long long, at least it is less keys to press when typing :)
--
Evgeniy Polyakov
prev parent reply other threads:[~2008-11-03 14:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 1:49 [PATCH V2 00/16] Squashfs: compressed read-only filesystem Phillip Lougher
2008-10-29 2:29 ` Andrew Morton
2009-01-04 7:55 ` Phillip Lougher
2009-01-04 19:04 ` Leon Woestenberg
2009-01-05 12:29 ` Pull request for Squashfs Phillip Lougher
2009-01-05 12:52 ` Stephen Rothwell
2009-01-05 13:03 ` Phillip Lougher
2009-01-05 13:37 ` Stephen Rothwell
2008-10-29 21:39 ` [PATCH V2 00/16] Squashfs: compressed read-only filesystem Matt Mackall
2008-10-31 0:29 ` Phillip Lougher
2008-11-03 14:14 ` Evgeniy Polyakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081103141450.GC27263@ioremap.net \
--to=zbr@ioremap.net \
--cc=akpm@linux-foundation.org \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phillip@lougher.demon.co.uk \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.